Skip to content

Commit 6eddc8f

Browse files
committed
Bugfix STAR validation
1 parent 0b26061 commit 6eddc8f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

SequenceAnalysis/src/org/labkey/sequenceanalysis/run/alignment/StarWrapper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -436,7 +436,7 @@ public Provider()
436436
put("extensions", Arrays.asList("gtf", "gff"));
437437
put("width", 400);
438438
put("allowBlank", true);
439-
put("getErrors", "js:function(){var errors = [];var val = this.getValue();var gtfField = this.up('panel').down('field[name=\"alignment.STAR.generateCounts\"]');if (gtfField && gtfField.getValue()) { errors.push('Must select a GTF when Generate Counts is selected') } return errors;}");
439+
put("getErrors", "js:function(){var errors = [];var val = this.getValue();var countField = this.up('panel').down('field[name=\"alignment.STAR.generateCounts\"]');if (!val && countField && countField.getValue()) { errors.push('Must select a GTF when Generate Counts is selected') } return errors;}");
440440
}}, null),
441441
ToolParameterDescriptor.create("generateCounts", "Generate Counts", "There are rare cases when STAR is used without a GTF, so this field is not required. If that field is left blank, counts are not generated. Checking this field prevents job submission unless a GTF is provided. Uncheck to allow running without a GTF.", "checkbox", new JSONObject(){{
442442
put("checked", true);

0 commit comments

Comments
 (0)