Lower allowableValues threshold to display multiSelect (#256)

* Lower allowableValues threshold to display multiSelect
* Add IMPACT test

---------

Co-authored-by: Sebastian Benjamin <sebastiancbenjamin@gmail.com>
Co-authored-by: bbimber <bbimber@gmail.com>

Author: 3 people

jbrowse/src/client/JBrowse/VariantSearch/components/FilterForm.tsx

@@ -276,7 +276,7 @@ const FilterForm = (props: FilterFormProps ) => {
                                             ))}
                                         </Select>
                                     </FormControlMinWidth>
-                                ) : fieldTypeInfo.find(obj => obj.name === filter.field)?.allowableValues?.length > 10 ? (
+                                ) : fieldTypeInfo.find(obj => obj.name === filter.field)?.allowableValues?.length > 1 ? (
                                     <FormControlMinWidth sx={ highlightedInputs[index]?.value ? highlightedSx : null } >
                                         <AsyncSelect
                                             id={`value-select-${index}`}
@@ -288,6 +288,7 @@ const FilterForm = (props: FilterFormProps ) => {
                                             menuShouldBlockScroll={true}
                                             styles={{menuPortal: base => ({...base, zIndex: 9999})}}
                                             isMulti={fieldTypeInfo.find(obj => obj.name === filter.field)?.isMultiValued}
+                                            defaultOptions={fieldTypeInfo.find(obj => obj.name === filter.field)?.allowableValues?.length < 20}
                                             loadOptions={(inputValue, callback) => {
                                                 const fieldInfo = fieldTypeInfo.find(obj => obj.name === filter.field);
 

jbrowse/src/org/labkey/jbrowse/JBrowseController.java

@@ -20,7 +20,6 @@
 import htsjdk.variant.variantcontext.Genotype;
 import htsjdk.variant.variantcontext.VariantContext;
 import htsjdk.variant.vcf.VCFFileReader;
-import htsjdk.variant.vcf.VCFHeaderLineType;
 import org.apache.commons.lang3.StringUtils;
 import org.apache.logging.log4j.Logger;
 import org.jetbrains.annotations.NotNull;

jbrowse/test/src/org/labkey/test/tests/external/labModules/JBrowseTest.java

@@ -1713,8 +1713,8 @@ private void testLuceneSearchUI(String sessionId)
         waitForElement(Locator.tagWithText("li", "Impact on Protein Coding")).click();
         waitForElement(Locator.tagWithAttribute("div", "aria-labelledby", "operator-label")).click();
         waitForElement(Locator.tagWithText("li", "equals")).click();
-        waitForElement(Locator.tagWithId("div", "value-select-0")).click();
-        waitForElement(Locator.tagWithText("li", "HIGH")).click();
+        waitForElement(Locator.tagWithId("input", "value-select-0")).sendKeys("HI");
+        waitForElement(Locator.tagWithId("input", "value-select-0")).sendKeys(Keys.ENTER);
         waitAndClick(Locator.tagWithClass("button", "filter-form-select-button"));
         waitForElementToDisappear(Locator.tagWithText("span", "4"));
         clearFilterDialog("IMPACT equals HIGH");
@@ -1798,5 +1798,20 @@ private void testLuceneSearchUI(String sessionId)
         waitAndClick(Locator.tagWithClass("button", "filter-form-select-button"));
         waitForElement(Locator.tagWithText("span", "914"));
         clearFilterDialog("IMPACT is not empty");
+
+        // IMPACT HIGH+MODERATE
+        waitAndClick(Locator.tagWithText("button", "Search"));
+        waitForElement(Locator.tagWithAttribute("div", "aria-labelledby", "field-label")).click();
+        waitForElement(Locator.tagWithText("li", "Impact on Protein Coding")).click();
+        waitForElement(Locator.tagWithAttribute("div", "aria-labelledby", "operator-label")).click();
+        waitForElement(Locator.tagWithText("li", "equals")).click();
+        waitForElement(Locator.tagWithId("input", "value-select-0")).sendKeys("HI");
+        waitForElement(Locator.tagWithId("input", "value-select-0")).sendKeys(Keys.ENTER);
+        waitForElement(Locator.tagWithId("input", "value-select-0")).sendKeys("MO");
+        waitForElement(Locator.tagWithId("input", "value-select-0")).sendKeys(Keys.ENTER);
+        waitAndClick(Locator.tagWithClass("button", "filter-form-select-button"));
+        waitForElement(Locator.tagWithText("span", "0.029"));
+
+        clearFilterDialog("IMPACT equals HIGH,MODERATE");
     }
 }