Skip to content

Commit 6246da2

Browse files
Update more third-party dependencies (#221)
1 parent 1e0e6c0 commit 6246da2

File tree

3 files changed

+5
-6
lines changed

3 files changed

+5
-6
lines changed

OpenLdapSync/src/org/labkey/openldapsync/ldap/LdapConnectionWrapper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ private LdapConnection getConnection() throws LdapException
9595
{
9696
try
9797
{
98-
LdapConnection connection = _pool.makeObject();
98+
LdapConnection connection = _pool.makeObject().getObject();
9999
connection.bind();
100100

101101
if (!connection.isConnected())

OpenLdapSync/src/org/labkey/openldapsync/ldap/LdapSyncRunner.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package org.labkey.openldapsync.ldap;
22

3-
import org.apache.commons.lang.StringUtils;
3+
import org.apache.commons.lang3.StringUtils;
44
import org.apache.directory.api.ldap.model.exception.LdapException;
55
import org.apache.directory.api.ldap.model.exception.LdapInvalidDnException;
66
import org.apache.directory.api.ldap.model.name.Dn;
@@ -347,7 +347,7 @@ private String getNameForGroup(LdapEntry group) throws LdapException
347347
//concatenate to the group name if the field is not empty
348348
if (StringUtils.trimToNull(_settings.getGroupNameSuffix()) != null)
349349
{
350-
//Note: do not trim the suffix, as this allows the admin to provide leading whitespace. for example: the suffix " (LDAP)" would result in "MyGroup (LDAP)"
350+
// Note: do not trim the suffix, as this allows the admin to provide leading whitespace. for example: the suffix " (LDAP)" would result in "MyGroup (LDAP)"
351351
groupName = groupName.concat(_settings.getGroupNameSuffix());
352352
}
353353

SequenceAnalysis/build.gradle

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ repositories {
2323
configurations.all {
2424
resolutionStrategy {
2525
force "com.sun.activation:jakarta.activation:${activationVersion}"
26-
force "javax.xml.bind:jaxb-api:2.3.0" // CONSIDER: Exclude jaxb-api? It's essentially the same jar as jakarta.xml.bind-api (below)
2726
// NOTE: this should be kept in sync with mcc module:
2827
force "jakarta.xml.bind:jakarta.xml.bind-api:${jaxbVersion}"
2928
}
@@ -61,8 +60,8 @@ dependencies {
6160
),
6261
{
6362
// Exclude activation jars from webapp to avoid classloader conflicts with <tomcat>/lib/javax.activation.jar
64-
exclude group: 'jakarta.activation', module: 'jakarta.activation-api'
6563
exclude group: 'com.sun.activation', module: 'jakarta.activation'
64+
exclude group: 'javax.activation', module: 'javax.activation-api'
6665
}
6766
)
6867

@@ -79,8 +78,8 @@ dependencies {
7978
),
8079
{
8180
// Exclude activation jars from webapp to avoid classloader conflicts with <tomcat>/lib/javax.activation.jar
82-
exclude group: 'jakarta.activation', module: 'jakarta.activation-api'
8381
exclude group: 'com.sun.activation', module: 'jakarta.activation'
82+
exclude group: 'javax.activation', module: 'javax.activation-api'
8483
}
8584
)
8685

0 commit comments

Comments
 (0)