Skip to content

Commit 5ab69ca

Browse files
committed
Bugfix to nimble append
1 parent 49d18da commit 5ab69ca

File tree

4 files changed

+5
-4
lines changed

4 files changed

+5
-4
lines changed

SequenceAnalysis/resources/web/SequenceAnalysis/field/GenomeField.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ Ext4.define('SequenceAnalysis.field.GenomeField', {
88
displayField: 'name',
99
valueField: 'rowid',
1010
queryMode: 'local',
11+
triggerAction: 'all',
1112
store: {
1213
type: 'labkey-store',
1314
schemaName: 'sequenceanalysis',

singlecell/resources/web/singlecell/panel/NimbleAppendPanel.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ Ext4.define('SingleCell.panel.NimbleAppendPanel', {
1313
minWidth: 650,
1414
border: true,
1515
items: [{
16-
html: 'This step will first run cellranger using the primary genome (selected above). The resulting BAM will be passed to nimble, which will align using each of the genomes selected below, creating supplemental feature counts. By default, the original cellranger output is discarded.',
16+
html: 'This step will query nimble results for the selected genome(s). It will then append these results to the seurat object on the target assay.',
1717
maxWidth: 600,
1818
border: false,
1919
style: 'padding-bottom: 10px;'
@@ -48,7 +48,7 @@ Ext4.define('SingleCell.panel.NimbleAppendPanel', {
4848
header: 'Genome',
4949
editor: this.genomeField,
5050
renderer: function(val){
51-
const store = this.up('singlecell-nimblealignpanel').genomeField.store
51+
const store = this.up('singlecell-nimbleappendpanel').genomeField.store
5252
if (val && store) {
5353
const recIdx = store.find('rowid', val);
5454
return store.getAt(recIdx).get('name');

singlecell/src/org/labkey/singlecell/run/NimbleAlignmentStep.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ public static class Provider extends AbstractAlignmentStepProvider<AlignmentStep
3232
{
3333
public Provider()
3434
{
35-
super("Nimble", "This will run Nimble to generate a supplemental feature count matrix for the provided libraries", getCellRangerGexParams(getToolParameters()), new LinkedHashSet<>(PageFlowUtil.set("sequenceanalysis/field/GenomeFileSelectorField.js", "sequenceanalysis/field/GenomeField.js", "singlecell/panel/NimbleAlignPanel.js")), null, true, false, ALIGNMENT_MODE.MERGE_THEN_ALIGN);
35+
super("Nimble", "This will run Nimble to generate a supplemental feature count matrix for the provided libraries", getCellRangerGexParams(getToolParameters()), new LinkedHashSet<>(PageFlowUtil.set("sequenceanalysis/field/GenomeField.js", "singlecell/panel/NimbleAlignPanel.js")), null, true, false, ALIGNMENT_MODE.MERGE_THEN_ALIGN);
3636
}
3737

3838
@Override

singlecell/src/org/labkey/singlecell/run/NimbleAnalysis.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ public static class Provider extends AbstractAnalysisStepProvider<NimbleAnalysis
2929
{
3030
public Provider()
3131
{
32-
super("NimbleAnalysis", "Nimble", null, "This will run Nimble to generate a supplemental feature count matrix for the provided libraries", NimbleAlignmentStep.getToolParameters(), new LinkedHashSet<>(PageFlowUtil.set("sequenceanalysis/field/GenomeFileSelectorField.js", "sequenceanalysis/field/GenomeField.js", "singlecell/panel/NimbleAlignPanel.js")), null);
32+
super("NimbleAnalysis", "Nimble", null, "This will run Nimble to generate a supplemental feature count matrix for the provided libraries", NimbleAlignmentStep.getToolParameters(), new LinkedHashSet<>(PageFlowUtil.set("sequenceanalysis/field/GenomeField.js", "singlecell/panel/NimbleAlignPanel.js")), null);
3333
}
3434

3535
@Override

0 commit comments

Comments
 (0)