Skip to content

Commit 5a5740f

Browse files
committed
Include all algorithms in hashing, even if some are not in consensusMethods
1 parent 846a5a2 commit 5a5740f

File tree

1 file changed

+2
-9
lines changed

1 file changed

+2
-9
lines changed

singlecell/src/org/labkey/singlecell/CellHashingServiceImpl.java

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1238,15 +1238,8 @@ public File generateCellHashingCalls(File citeSeqCountOutDir, File outputDir, St
12381238
Set<String> allowableBarcodes = parameters.getAllowableBarcodeNames();
12391239
String allowableBarcodeParam = allowableBarcodes != null ? "c('" + StringUtils.join(allowableBarcodes, "','") + "')" : "NULL";
12401240

1241-
List<String> methodNames = parameters.methods.stream().filter(m -> {
1242-
if (totalCellBarcodes < m.getMinCells())
1243-
{
1244-
ctx.getLogger().debug("Dropping method due to insufficient cells: " + m.name());
1245-
return false;
1246-
}
1247-
1248-
return true;
1249-
}).map(CALLING_METHOD::getLabel).distinct().toList();
1241+
// NOTE: we do not need to filter total methods on min cells:
1242+
List<String> methodNames = parameters.methods.stream().map(CALLING_METHOD::getLabel).distinct().toList();
12501243

12511244
List<String> consensusMethodNames = parameters.consensusMethods == null ? Collections.emptyList() : parameters.consensusMethods.stream().filter(m -> {
12521245
if (totalCellBarcodes < m.getMinCells())

0 commit comments

Comments
 (0)