Skip to content

Commit 500324e

Browse files
committed
Improve Illumina sample sheet export
1 parent c9ed9fe commit 500324e

File tree

3 files changed

+19
-5
lines changed

3 files changed

+19
-5
lines changed

SequenceAnalysis/resources/web/SequenceAnalysis/panel/IlluminaSampleExportPanel.js

Lines changed: 17 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,7 @@ Ext4.define('SequenceAnalysis.panel.IlluminaSampleExportPanel', {
9999
allowBlank: false,
100100
displayField: 'name',
101101
valueField: 'name',
102+
value: 'FASTQ Only',
102103
store: Ext4.create('LABKEY.ext4.data.Store', {
103104
schemaName: 'sequenceanalysis',
104105
queryName: 'illumina_applications',
@@ -117,7 +118,7 @@ Ext4.define('SequenceAnalysis.panel.IlluminaSampleExportPanel', {
117118
scope: this,
118119
change: function(field, val){
119120
var kitField = field.up('panel').down('#sampleKit');
120-
if (!val || val == 'Custom'){
121+
if (!val || val === 'Custom'){
121122
kitField.setDisabled(true);
122123
return;
123124
}
@@ -171,6 +172,12 @@ Ext4.define('SequenceAnalysis.panel.IlluminaSampleExportPanel', {
171172
helpPopup: 'Leave blank for single-end reads',
172173
itemId: 'cycles2',
173174
fieldLabel: 'Cycles Read 2'
175+
},{
176+
xtype: 'checkbox',
177+
itemId: 'nameUsingRowId',
178+
fieldLabel: 'Name FASTA Using Row Id',
179+
value: true,
180+
helpPopup: 'If checked, the FASTQs will be named using the numeric rowId, which can make import more automatic. If unchecked, they will be named using readset name.'
174181
},{
175182
xtype: 'combo',
176183
itemId: 'genomeFolder',
@@ -591,6 +598,7 @@ Ext4.define('SequenceAnalysis.panel.IlluminaSampleExportPanel', {
591598

592599
var genomeFolder = '';
593600
var genomeField = this.down('#genomeFolder');
601+
var nameUsingRowId = this.down('#nameUsingRowId').getValue();
594602
if (genomeField.getValue()){
595603
var recIdx = genomeField.store.find(genomeField.valueField, genomeField.getValue());
596604
var rec = genomeField.store.getAt(recIdx);
@@ -599,7 +607,7 @@ Ext4.define('SequenceAnalysis.panel.IlluminaSampleExportPanel', {
599607

600608
var sampleColumns = [
601609
['Sample_ID', 'rowid'],
602-
['Sample_Name', 'name'],
610+
['Sample_Name', 'name', function(row) { return nameUsingRowId ? 's_' + row.rowid : row.name; }],
603611
['Sample_Plate', ''],
604612
['Sample_Well', ''],
605613
['Sample_Project', ''],
@@ -621,7 +629,13 @@ Ext4.define('SequenceAnalysis.panel.IlluminaSampleExportPanel', {
621629
var toAdd = [];
622630
Ext4.each(sampleColumns, function(col){
623631
if (col.length > 2){
624-
toAdd.push(col[2]);
632+
if (Ext4.isFunction(col[2])) {
633+
toAdd.push(col[2](row));
634+
}
635+
else {
636+
toAdd.push(col[2]);
637+
}
638+
625639
}
626640
else {
627641
toAdd.push(row[col[1]]);

SequenceAnalysis/src/org/labkey/sequenceanalysis/pipeline/OrphanFilePipelineJob.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -552,7 +552,7 @@ private void getOrphanFilesForDirectory(Set<Integer> knownExpDatas, Map<URI, Set
552552
continue;
553553
else if (f.getPath().contains("/Normalization/") && f.getName().contains("_unknowns"))
554554
continue;
555-
else if (f.getPath().contains("/Alignment/") && (f.getName().contains("unaligned") || f.getName().contains("unmapped") || f.getName().contains(".overlapping-")))
555+
else if (f.getPath().contains("/outs/") || f.getPath().contains("/Alignment/") && (f.getName().contains("unaligned") || f.getName().contains("unmapped") || f.getName().contains(".overlapping-")))
556556
continue;
557557
}
558558

SequenceAnalysis/src/org/labkey/sequenceanalysis/run/analysis/MergeLoFreqVcfHandler.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -500,7 +500,7 @@ public void processFilesRemote(List<SequenceOutputFile> inputFiles, JobContext c
500500
double diff = Math.abs(adjAF - af);
501501
if (diff > 0.01)
502502
{
503-
ctx.getLogger().error("Significant AF adjustment: readset: " + line.get(0) + " / site: " + line.get(4) + " / allele: " + a + " / AF: " + af + " / New AF" + adjAF + " / diff: " + diff + " / gatk depth: " + gatkDepth + " / lofreq depth: " + lofreqDepth);
503+
ctx.getLogger().warn("Significant AF adjustment: readset: " + line.get(0) + " / site: " + line.get(4) + " / allele: " + a + " / AF: " + af + " / New AF" + adjAF + " / diff: " + diff + " / gatk depth: " + gatkDepth + " / lofreq depth: " + lofreqDepth);
504504
}
505505

506506
totalAltAf += adjAF;

0 commit comments

Comments
 (0)