Avoid ArrayIndexOutOfBoundsException when slurm line has empty values

bbimber · bbimber · commit 49ce0ecc244e · 2022-01-04T13:26:33.000-08:00
diff --git a/cluster/src/org/labkey/cluster/pipeline/SlurmExecutionEngine.java b/cluster/src/org/labkey/cluster/pipeline/SlurmExecutionEngine.java
@@ -277,7 +277,8 @@ else if (headerFound)
                             }
                         }
 
-                        if (maxRssIdx > -1)
+                        // NOTE: if the line has blank ending columns, trimmed lines might lack that value
+                        if (maxRssIdx > -1 && maxRssIdx < tokens.length)
                         {
                             long bytes = FileSizeFormatter.convertStringRepresentationToBytes(tokens[maxRssIdx]);
                             long requestInBytes = FileSizeFormatter.convertBytesToUnit(getConfig().getRequestMemory(), 'G');

Original file line number	Diff line number	Diff line change
`@@ -277,7 +277,8 @@ else if (headerFound)`
`277`	`277`	`}`
`278`	`278`	`}`
`279`	`279`
`280`		`- if (maxRssIdx > -1)`
	`280`	`+ // NOTE: if the line has blank ending columns, trimmed lines might lack that value`
	`281`	`+ if (maxRssIdx > -1 && maxRssIdx < tokens.length)`
`281`	`282`	`{`
`282`	`283`	`long bytes = FileSizeFormatter.convertStringRepresentationToBytes(tokens[maxRssIdx]);`
`283`	`284`	`long requestInBytes = FileSizeFormatter.convertBytesToUnit(getConfig().getRequestMemory(), 'G');`