Skip to content

Commit 38f8435

Browse files
committed
Bugfix to NA check in CheckExpectations
1 parent 48c4caf commit 38f8435

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

singlecell/resources/chunks/CheckExpectations.R

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
CheckField <- function(seuratObj, datasetId, fieldName, errorOnNA= TRUE) {
1+
CheckField <- function(seuratObj, datasetId, fieldName, errorOnNA = TRUE) {
22
if (!fieldName %in% names(seuratObj@meta.data)) {
33
addErrorMessage(paste0(paste0('Missing ', fieldName, ' for dataset: ', datasetId)))
44
}
55

6-
if (any(is.na(seuratObj@meta.data[[fieldName]]))) {
6+
if (errorOnNA && any(is.na(seuratObj@meta.data[[fieldName]]))) {
77
addErrorMessage(paste0(paste0('NA values found for ', fieldName, ' for dataset: ', datasetId)))
88
}
99
}

singlecell/resources/chunks/SeuratPrototype.R

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
CheckField <- function(seuratObj, datasetId, fieldName) {
1+
CheckField <- function(seuratObj, datasetId, fieldName, errorOnNA = TRUE) {
22
if (!fieldName %in% names(seuratObj@meta.data)) {
33
addErrorMessage(paste0(paste0('Missing ', fieldName, ' for dataset: ', datasetId)))
44
}
55

6-
if (any(is.na(seuratObj@meta.data[[fieldName]]))) {
6+
if (errorOnNA && any(is.na(seuratObj@meta.data[[fieldName]]))) {
77
addErrorMessage(paste0(paste0('NA values found for ', fieldName, ' for dataset: ', datasetId)))
88
}
99
}
@@ -87,7 +87,7 @@ for (datasetId in names(seuratObjects)) {
8787
}
8888

8989
if (requireScGate) {
90-
CheckField(seuratObj, datasetId, 'scGateConsensus')
90+
CheckField(seuratObj, datasetId, 'scGateConsensus', errorOnNA = FALSE)
9191
}
9292

9393
if (length(errorMessages) > 0) {

0 commit comments

Comments
 (0)