Skip to content

Commit 312d299

Browse files
committed
Update CellBender defaults
1 parent a20af1d commit 312d299

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

singlecell/src/org/labkey/singlecell/run/CellBenderCiteSeqHandler.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,17 +27,17 @@ public class CellBenderCiteSeqHandler extends AbstractParameterizedOutputHandler
2727
{
2828
public CellBenderCiteSeqHandler()
2929
{
30-
super(ModuleLoader.getInstance().getModule(SingleCellModule.class), "Run CellBender (CITE-seq)", "This will run cellbender on the input cellranger folder and create a subset matrix with background/ambient noise removed.", null, getParams());
30+
super(ModuleLoader.getInstance().getModule(SingleCellModule.class), "Run CellBender (CITE-seq)", "This will run cellbender on the input cellranger folder and create a subset matrix with background/ambient noise removed.", null, getParams(0.05));
3131
}
3232

33-
protected static List<ToolParameterDescriptor> getParams()
33+
protected static List<ToolParameterDescriptor> getParams(double fpr)
3434
{
3535
return Arrays.asList(
3636
ToolParameterDescriptor.createCommandLineParam(CommandLineParam.create("--expected-cells"), "expectedCells", "Expected Cells", "Passed to CellBender --expected-cells", "ldk-integerfield", null, 5000),
3737
ToolParameterDescriptor.createCommandLineParam(CommandLineParam.create("--total-droplets-included"), "totalDropletsIncluded", "Total Droplets Included", "Passed to CellBender --total-droplets-included", "ldk-integerfield", null, 20000),
38-
ToolParameterDescriptor.createCommandLineParam(CommandLineParam.create("--fpr"), "fpr", "fpr Cells", "Passed to CellBender --fpr", "ldk-numberfield", new JSONObject(){{
38+
ToolParameterDescriptor.createCommandLineParam(CommandLineParam.create("--fpr"), "fpr", "FPR", "Passed to CellBender --fpr", "ldk-numberfield", new JSONObject(){{
3939
put("decimalPrecision", 3);
40-
}}, 0.05),
40+
}}, fpr),
4141
ToolParameterDescriptor.createCommandLineParam(CommandLineParam.create("--epochs"), "epochs", "Epochs", "Passed to CellBender --epochs", "ldk-integerfield", null, 150),
4242
ToolParameterDescriptor.createCommandLineParam(CommandLineParam.createSwitch("--cuda"), "useGpus", "Use GPUs", "If checked, the --cuda argument will be set on cellbender", "checkbox", null, false)
4343
);

singlecell/src/org/labkey/singlecell/run/CellBenderLoupeHandler.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ public class CellBenderLoupeHandler extends AbstractParameterizedOutputHandler<S
2323
{
2424
public CellBenderLoupeHandler()
2525
{
26-
super(ModuleLoader.getInstance().getModule(SingleCellModule.class), "Run CellBender (RNA-seq)", "This will run cellbender on the input cellranger folder and create a subset matrix with background/ambient noise removed.", null, CellBenderCiteSeqHandler.getParams());
26+
super(ModuleLoader.getInstance().getModule(SingleCellModule.class), "Run CellBender (RNA-seq)", "This will run cellbender on the input cellranger folder and create a subset matrix with background/ambient noise removed.", null, CellBenderCiteSeqHandler.getParams(0.01));
2727
}
2828

2929
@Override

0 commit comments

Comments
 (0)