Bugfix to JBrowse default hidden columns

Author: bbimber

jbrowse/src/client/JBrowse/VariantSearch/components/VariantTableWidget.tsx

@@ -216,7 +216,7 @@ const VariantTableWidget = observer(props => {
   const [filterModalOpen, setFilterModalOpen] = useState(false);
   const [filters, setFilters] = useState([]);
   const [fieldTypeInfo, setFieldTypeInfo] = useState<FieldModel[]>([]);
-  const [hiddenColumns, setHiddenColumns] = useState([]);
+  const [hiddenColumns, setHiddenColumns] = useState<String[]>([]);
 
   const [adapter, setAdapter] = useState<EVAdapterClass | undefined>(undefined)
 
@@ -247,7 +247,8 @@ const VariantTableWidget = observer(props => {
               }
           })
 
-          setColumns(columns);
+          setColumns(columns)
+          setHiddenColumns(columns.filter((x) => !x.hide).map((x) => x.field))
           const operators = fieldTypeInfoToOperators(res)
           setAvailableOperators(operators)
           setFieldTypeInfo(res)

jbrowse/src/client/JBrowse/VariantSearch/constants.tsx

@@ -1,7 +1,13 @@
-import { GridColumns, GridComparatorFn, getGridNumericColumnOperators, GridFilterOperator, GridFilterItem, GridStateColDef, GridCellParams } from '@mui/x-data-grid';
-import { arrayMax } from '../utils'
+import {
+  GridCellParams,
+  GridComparatorFn,
+  GridFilterItem,
+  GridFilterOperator,
+  GridStateColDef
+} from '@mui/x-data-grid';
+import { arrayMax } from '../utils';
 
-const parseCellValue = (cellValue) => (cellValue.valueOf() as string).split(",").map(str => {
+export const parseCellValue = (cellValue) => JSON.stringify(cellValue ?? "").split(",").map(str => {
   return Number(str);
 })
 

jbrowse/src/client/JBrowse/VariantTable/constants.tsx

@@ -1,5 +1,14 @@
-import { GridColumns, GridComparatorFn, getGridNumericColumnOperators, GridFilterOperator, GridFilterItem, GridStateColDef, GridCellParams } from '@mui/x-data-grid';
-import { arrayMax } from '../utils'
+import {
+  getGridNumericColumnOperators,
+  GridCellParams,
+  GridColumns,
+  GridComparatorFn,
+  GridFilterItem,
+  GridFilterOperator,
+  GridStateColDef
+} from '@mui/x-data-grid';
+import { arrayMax } from '../utils';
+import { parseCellValue } from '../VariantSearch/constants';
 
 // TODO: we need to look into this for all numeric fields. Because some attributes are per-allele,
 // The value of these attributes is a CSV string. See comments in dataUtils/rawFeatureToRow()
@@ -15,9 +24,6 @@ import { arrayMax } from '../utils'
 //     val ? Number(val).toLocaleString(navigator.language, {maximumFractionDigits: 6}) : val
 //   }).join(', ')
 // }
-const parseCellValue = (cellValue) => (cellValue.valueOf() as string).split(",").map(str => {
-  return Number(str);
-})
 
 const multiValueComparator: GridComparatorFn = (v1, v2) => {
   return arrayMax(parseCellValue(v1)) - arrayMax(parseCellValue(v2))