Skip to content

Commit 2774d91

Browse files
author
Sebastian Benjamin
committed
Fix filterForm not displaying full csv values
1 parent dd79ea7 commit 2774d91

File tree

3 files changed

+8
-6
lines changed

3 files changed

+8
-6
lines changed

jbrowse/src/client/JBrowse/VariantSearch/components/FilterForm.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,8 @@ const FilterForm = (props: FilterFormProps ) => {
9898
return i !== index;
9999
})
100100
);
101-
}};
101+
}
102+
};
102103

103104
const handleFilterChange = (index, key, value) => {
104105
const newFilters = filters.map((filter, i) => {

jbrowse/src/client/JBrowse/VariantSearch/components/VariantTableWidget.tsx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import {
1111
GridToolbarExport
1212
} from '@mui/x-data-grid';
1313
import SearchIcon from '@mui/icons-material/Search';
14-
import React, { useEffect, useState } from 'react';
14+
import React, { useEffect, useState, useMemo } from 'react';
1515
import { getConf } from '@jbrowse/core/configuration';
1616
import { AppBar, Box, Button, Dialog, Paper, Popover, Toolbar, Tooltip, Typography } from '@mui/material';
1717
import ArrowPagination from './ArrowPagination';
@@ -337,9 +337,6 @@ const VariantTableWidget = observer(props => {
337337
}
338338

339339
const feature = extendedFeatures[0]
340-
console.log(feature)
341-
console.log(row)
342-
343340
const trackId = getConf(track, 'trackId')
344341
const detailsConfig = getConf(track, ['displays', '0', 'detailsConfig'])
345342
const widgetId = 'Variant-' + trackId;
@@ -410,6 +407,7 @@ const VariantTableWidget = observer(props => {
410407
);
411408
};
412409

410+
413411
const filterModal = (
414412
<FilterFormModal
415413
open={filterModalOpen}

jbrowse/src/client/JBrowse/utils.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -583,7 +583,10 @@ export class Filter implements FilterType {
583583
const searchStringsArray = decodedSearchString.split("&").filter((x) => x !== "all")
584584

585585
return searchStringsArray.map((item) => {
586-
const [field, operator, value] = item.split(",")
586+
const parts = item.split(",");
587+
const field = parts[0];
588+
const operator = parts[1];
589+
const value = parts.slice(2).join(",");
587590
return Object.assign(new Filter(), { field: field, operator: operator, value: value })
588591
})
589592
}

0 commit comments

Comments
 (0)