Skip to content

Commit 26610dd

Browse files
committed
Specify threads for trimmomatic instead of letting it detect
1 parent ef035aa commit 26610dd

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

SequenceAnalysis/api-src/org/labkey/api/sequenceanalysis/run/AbstractCommandWrapper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ private void execute(List<String> params, ProcessBuilder.Redirect redirect, @Nul
154154
try (BufferedReader procReader = new BufferedReader(new InputStreamReader(redirect == null ? p.getInputStream() : p.getErrorStream(), StringUtilsLabKey.DEFAULT_CHARSET)))
155155
{
156156
String line;
157-
while (p.isAlive() && (line = procReader.readLine()) != null)
157+
while ((line = procReader.readLine()) != null)
158158
{
159159
if (output != null)
160160
{

SequenceAnalysis/src/org/labkey/sequenceanalysis/run/preprocessing/TrimmomaticWrapper.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -564,13 +564,13 @@ public List<String> getTrimmomaticParams(File input, @Nullable File input2, Stri
564564
params.add("-phred" + FastqUtils.getQualityOffset(encoding));
565565
}
566566

567-
//NOTE: the tool auto-detects
568-
//Integer threads = SequenceTaskHelper.getMaxThreads(job);
569-
//if (threads != null)
570-
//{
571-
// params.add("-threads"); //multi-threaded
572-
// params.add(threads.toString());
573-
//}
567+
Integer threads = SequenceTaskHelper.getMaxThreads(getLogger());
568+
if (threads != null)
569+
{
570+
threads = Math.min(1, threads - 1); //account for reading of log
571+
params.add("-threads");
572+
params.add(threads.toString());
573+
}
574574

575575
params.add(input.getPath());
576576
if (input2 != null)
@@ -673,7 +673,7 @@ public void run()
673673
boolean haveReportedInvalidHeader = false;
674674

675675
String line;
676-
while (p.isAlive() && (line = reader.readLine()) != null)
676+
while ((line = reader.readLine()) != null)
677677
{
678678
String[] cells = line.split(" ");
679679
if (cells.length < 4)

0 commit comments

Comments
 (0)