Skip to content

Commit 204e6d4

Browse files
committed
Bugfix JBrowse sample filtering
1 parent 62d8c09 commit 204e6d4

File tree

2 files changed

+9
-8
lines changed

2 files changed

+9
-8
lines changed

jbrowse/src/client/JBrowse/Browser/plugins/ExtendedVariantPlugin/ExtendedVariantRenderer/components/SvgFeatureRendering.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ function passesSampleFilters(feature, sampleIDs){
177177
const gt = feature.variant.SAMPLES[sampleId]["GT"][0]
178178

179179
// If any sample in the whitelist is non-WT, show this site. Otherwise filter.
180-
if (!isVariant(gt)) {
180+
if (isVariant(gt)) {
181181
return true
182182
}
183183
}

jbrowse/test/src/org/labkey/test/tests/external/labModules/JBrowseTest.java

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ private void testDefaultColorApplied()
151151
waitForJBrowseToLoad();
152152

153153
// Indicates AF scheme applied:
154-
waitForElement(Locator.tagWithAttribute("polygon", "fill", "#831A7D"));
154+
waitForElement(Locator.tagWithAttribute("polygon", "fill", "#9A1764"));
155155

156156
openTrackMenuItem("Color Selection");
157157
waitForElement(Locator.tagWithText("h6", "Color Schemes"));
@@ -238,6 +238,7 @@ private void testFilterWidget()
238238
waitAndClick(Locator.tagContainingText("li", "<"));
239239

240240
clickDialogButton("Apply");
241+
sleep(1000);
241242

242243
Assert.assertEquals("Incorrect number of variants", 21, getTotalVariantFeatures());
243244
}
@@ -298,7 +299,7 @@ private void testSampleFilters()
298299
Locator.findElements(getDriver(), textArea).get(0).sendKeys("m00010");
299300
clickDialogButton("Apply");
300301

301-
Assert.assertEquals("Incorrect number of variants", 20, getTotalVariantFeatures());
302+
Assert.assertEquals("Incorrect number of variants", 18, getTotalVariantFeatures());
302303
}
303304

304305
private void testInferredDetails()
@@ -307,10 +308,10 @@ private void testInferredDetails()
307308
waitForJBrowseToLoad();
308309

309310
Actions actions = new Actions(getDriver());
310-
WebElement toClick = getDriver().findElements(getVariantWithinTrack("mgap_hg38", "SNV G -> A")).stream().filter(WebElement::isDisplayed).findFirst().get();
311+
WebElement toClick = getDriver().findElements(getVariantWithinTrack("mgap_hg38", "SNV A -> C")).stream().filter(WebElement::isDisplayed).findFirst().get();
311312

312313
actions.click(toClick).perform();
313-
waitForElement(Locator.tagWithText("div", "1:116,986,951..116,986,951"));
314+
waitForElement(Locator.tagWithText("div", "1:116,992,079..116,992,079"));
314315
waitForElement(Locator.tagWithText("span", "Predicted Function"));
315316
waitForElement(Locator.tagWithText("span", "Regulatory Data"));
316317
waitForElement(Locator.tagWithText("span", "Phenotypic Data"));
@@ -329,9 +330,9 @@ private void testSampleFiltersFromUrl()
329330
checker().takeScreenShot("Jbrowse3_OnLoad");
330331

331332
// Wait for variants to load:
332-
getDriver().findElements(getVariantWithinTrack("mgap_hg38", "SNV A -> T"));
333+
getDriver().findElements(getVariantWithinTrack("mgap_hg38", "SNV A -> G"));
333334

334-
Assert.assertEquals("Incorrect number of variants", 20, getTotalVariantFeatures());
335+
Assert.assertEquals("Incorrect number of variants", 18, getTotalVariantFeatures());
335336

336337
openTrackMenuItem("Filter By Sample");
337338
waitForElement(Locator.tagWithText("h6", "Filter By Sample"));
@@ -687,4 +688,4 @@ private void testSearch(String sessionId) throws Exception
687688
}
688689
);
689690
}
690-
}
691+
}

0 commit comments

Comments
 (0)