Fix value-reset flow on filters without freely-enterable values

Author: Sebastian Benjamin

jbrowse/src/client/JBrowse/VariantSearch/components/FilterForm.tsx

@@ -103,12 +103,24 @@ const FilterForm = (props: FilterFormProps ) => {
     const handleFilterChange = (index, key, value) => {
         const newFilters = filters.map((filter, i) => {
             if (i === index) {
-                return Object.assign(new Filter(), { ...filter, [key]: value });
+                const updatedFilter = Object.assign(new Filter(), { ...filter, [key]: value });
+
+                if (key === "operator") {
+                    if (value === "is empty" || value === "is not empty") {
+                        updatedFilter.value = '';
+                    }
+
+                    if (value === "in set" || filter.operator === "in set") {
+                        updatedFilter.value = ''; 
+                    }
+                }
+
+                return updatedFilter;
             }
             return filter;
         });
 
-        localSetFilters(newFilters)
+        localSetFilters(newFilters);
     };
 
     const handleSubmit = (event) => {
@@ -262,6 +274,7 @@ const FilterForm = (props: FilterFormProps ) => {
                                         <Select
                                             labelId="value-select-label"
                                             value={filter.value}
+                                            disabled={filter.operator === "is empty" || filter.operator === "is not empty"}
                                             onChange={(event) =>
                                                 handleFilterChange(index, "value", event.target.value)
                                             }
@@ -278,6 +291,7 @@ const FilterForm = (props: FilterFormProps ) => {
                                         label="Value"
                                         sx={ highlightedInputs[index]?.value ? highlightedSx : null }
                                         value={filter.value}
+                                        disabled={filter.operator === "is empty" || filter.operator === "is not empty"}
                                         onChange={(event) =>
                                             handleFilterChange(index, 'value', event.target.value)
                                         }