Skip to content

Commit 01d4c91

Browse files
committed
Add reference arg to CollectInsertSizeMetrics
1 parent d3ae0dd commit 01d4c91

File tree

5 files changed

+10
-7
lines changed

5 files changed

+10
-7
lines changed

SequenceAnalysis/src/org/labkey/sequenceanalysis/analysis/PicardAlignmentMetricsHandler.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -258,7 +258,7 @@ public void processFilesRemote(List<SequenceOutputFile> inputFiles, JobContext c
258258
File metricsFile = new File(ctx.getOutputDir(), FileUtil.getBaseName(o.getFile()) + ".insertsize.metrics");
259259
File metricsHistogram = new File(ctx.getOutputDir(), FileUtil.getBaseName(o.getFile()) + ".insertsize.metrics.pdf");
260260
CollectInsertSizeMetricsWrapper wrapper = new CollectInsertSizeMetricsWrapper(job.getLogger());
261-
wrapper.executeCommand(o.getFile(), metricsFile, metricsHistogram);
261+
wrapper.executeCommand(o.getFile(), metricsFile, metricsHistogram, ctx.getSequenceSupport().getCachedGenome(o.getLibrary_id()).getWorkingFastaFile());
262262
}
263263

264264
if (runMarkDuplicates)

SequenceAnalysis/src/org/labkey/sequenceanalysis/pipeline/AlignmentNormalizationTask.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -268,7 +268,7 @@ else if (step.expectToCreateNewBam())
268268
getJob().setStatus(PipelineJob.TaskStatus.running, "CALCULATING INSERT SIZE METRICS");
269269
File metricsFile2 = new File(finalDestination.getParentFile(), FileUtil.getBaseName(finalDestination) + ".insertsize.metrics");
270270
File metricsHistogram = new File(finalDestination.getParentFile(), FileUtil.getBaseName(finalDestination) + ".insertsize.metrics.pdf");
271-
if (new CollectInsertSizeMetricsWrapper(getJob().getLogger()).executeCommand(finalDestination, metricsFile2, metricsHistogram) != null)
271+
if (new CollectInsertSizeMetricsWrapper(getJob().getLogger()).executeCommand(finalDestination, metricsFile2, metricsHistogram, referenceGenome.getWorkingFastaFile()) != null)
272272
{
273273
getTaskHelper().getFileManager().addOutput(metricsAction, "Insert Size Metrics File", metricsFile2);
274274
getTaskHelper().getFileManager().addOutput(metricsAction, "Insert Size Metrics Histogram", metricsHistogram);

SequenceAnalysis/src/org/labkey/sequenceanalysis/pipeline/SequenceAlignmentTask.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1014,7 +1014,7 @@ else if (step.expectToCreateNewBam())
10141014
File metricsFile2 = new File(renamedBam.getParentFile(), FileUtil.getBaseName(renamedBam) + ".insertsize.metrics");
10151015
File metricsHistogram = new File(renamedBam.getParentFile(), FileUtil.getBaseName(renamedBam) + ".insertsize.metrics.pdf");
10161016
CollectInsertSizeMetricsWrapper collectInsertSizeMetricsWrapper = new CollectInsertSizeMetricsWrapper(getJob().getLogger());
1017-
if (collectInsertSizeMetricsWrapper.executeCommand(renamedBam, metricsFile2, metricsHistogram) != null)
1017+
if (collectInsertSizeMetricsWrapper.executeCommand(renamedBam, metricsFile2, metricsHistogram, referenceGenome.getWorkingFastaFile()) != null)
10181018
{
10191019
getHelper().getFileManager().addOutput(metricsAction, "Insert Size Metrics File", metricsFile2);
10201020
getHelper().getFileManager().addOutput(metricsAction, "Insert Size Metrics Histogram", metricsHistogram);

SequenceAnalysis/src/org/labkey/sequenceanalysis/run/analysis/PindelAnalysis.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -156,15 +156,15 @@ private static String parseInsertMetrics(File inputFile, int minInsertSize) thro
156156
return null;
157157
}
158158

159-
private static String inferInsertSize(PipelineContext ctx, File bam, int minInsertSize) throws PipelineJobException
159+
private static String inferInsertSize(PipelineContext ctx, File bam, File fasta, int minInsertSize) throws PipelineJobException
160160
{
161161
File expectedPicard = new File(bam.getParentFile(), FileUtil.getBaseName(bam.getName()) + ".insertsize.metrics");
162162
if (!expectedPicard.exists())
163163
{
164164
ctx.getLogger().debug("Unable to find insert metrics file, creating: " + expectedPicard.getPath());
165165
CollectInsertSizeMetricsWrapper wrapper = new CollectInsertSizeMetricsWrapper(ctx.getLogger());
166166
File histFile = new File(expectedPicard.getPath() + ".hist");
167-
wrapper.executeCommand(bam, expectedPicard, histFile);
167+
wrapper.executeCommand(bam, expectedPicard, histFile, fasta);
168168
histFile.delete();
169169

170170
if (!expectedPicard.exists())
@@ -216,7 +216,7 @@ public static File runPindel(AnalysisOutputImpl output, PipelineContext ctx, Rea
216216
File pindelParams = new File(outDir, "pindelCfg.txt");
217217
try (CSVWriter writer = new CSVWriter(PrintWriters.getPrintWriter(pindelParams), '\t', CSVWriter.NO_QUOTE_CHARACTER))
218218
{
219-
String insertSize = inferInsertSize(ctx, inputBam, minInsertSize);
219+
String insertSize = inferInsertSize(ctx, inputBam, fasta, minInsertSize);
220220
writer.writeNext(new String[]{bamToUse.getPath(), insertSize, FileUtil.makeLegalName(rs.getName())});
221221
}
222222
catch (IOException e)

SequenceAnalysis/src/org/labkey/sequenceanalysis/run/util/CollectInsertSizeMetricsWrapper.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ public CollectInsertSizeMetricsWrapper(@Nullable Logger logger)
2020
super(logger);
2121
}
2222

23-
public File executeCommand(File inputFile, File outputFile, File histogramFile) throws PipelineJobException
23+
public File executeCommand(File inputFile, File outputFile, File histogramFile, File fasta) throws PipelineJobException
2424
{
2525
getLogger().info("Running CollectInsertSizeMetrics: " + inputFile.getPath());
2626
File idx = SequenceAnalysisService.get().getExpectedBamOrCramIndex(inputFile);
@@ -39,6 +39,9 @@ public File executeCommand(File inputFile, File outputFile, File histogramFile)
3939
params.add("--OUTPUT");
4040
params.add(outputFile.getPath());
4141

42+
params.add("-R");
43+
params.add(fasta.getPath());
44+
4245
params.add("-H");
4346
params.add(histogramFile.getPath());
4447

0 commit comments

Comments
 (0)