Skip to content

Commit c1964d4

Browse files
committed
Prefer bcftools/liftover
1 parent f0f425f commit c1964d4

File tree

5 files changed

+10
-90
lines changed

5 files changed

+10
-90
lines changed

mGAP/src/org/labkey/mgap/pipeline/AnnotationStep.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
import org.labkey.api.sequenceanalysis.pipeline.VariantProcessingStep;
3232
import org.labkey.api.sequenceanalysis.pipeline.VariantProcessingStepOutputImpl;
3333
import org.labkey.api.sequenceanalysis.run.AbstractCommandPipelineStep;
34+
import org.labkey.api.sequenceanalysis.run.LiftoverBcfToolsWrapper;
3435
import org.labkey.api.sequenceanalysis.run.SelectVariantsWrapper;
3536
import org.labkey.api.util.PageFlowUtil;
3637
import org.labkey.api.writer.PrintWriters;
@@ -327,8 +328,8 @@ public Output processVariants(File inputVCF, File outputDirectory, ReferenceGeno
327328
File liftoverRejects = new File(outputDirectory, SequenceAnalysisService.get().getUnzippedBaseName(currentVcf.getName()) + ".liftoverReject" + grch37Genome.getGenomeId() + ".vcf.gz");
328329
if (!indexExists(liftoverRejects) || !indexExists(liftedToGRCh37))
329330
{
330-
LiftoverVcfRunner liftoverVcfRunner = new LiftoverVcfRunner(getPipelineCtx().getLogger());
331-
liftoverVcfRunner.doLiftover(currentVcf, chainFile, grch37Genome.getWorkingFastaFile(), liftoverRejects, liftedToGRCh37, 0.95);
331+
LiftoverBcfToolsWrapper liftoverVcfRunner = new LiftoverBcfToolsWrapper(getPipelineCtx().getLogger());
332+
liftoverVcfRunner.doLiftover(currentVcf, chainFile, genome.getWorkingFastaFile(), grch37Genome.getWorkingFastaFile(), liftoverRejects, liftedToGRCh37);
332333
}
333334
else
334335
{

mGAP/src/org/labkey/mgap/pipeline/LiftoverVcfRunner.java

Lines changed: 0 additions & 80 deletions
This file was deleted.

mGAP/src/org/labkey/mgap/pipeline/mGapReleaseGenerator.java

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@
3131
import org.labkey.api.data.TableSelector;
3232
import org.labkey.api.exp.api.ExpData;
3333
import org.labkey.api.exp.api.ExperimentService;
34-
import org.labkey.api.jbrowse.JBrowseService;
3534
import org.labkey.api.module.ModuleLoader;
3635
import org.labkey.api.pipeline.PipelineJob;
3736
import org.labkey.api.pipeline.PipelineJobException;
@@ -56,6 +55,7 @@
5655
import org.labkey.api.sequenceanalysis.pipeline.SequenceOutputHandler;
5756
import org.labkey.api.sequenceanalysis.pipeline.ToolParameterDescriptor;
5857
import org.labkey.api.sequenceanalysis.run.GeneToNameTranslator;
58+
import org.labkey.api.sequenceanalysis.run.LiftoverBcfToolsWrapper;
5959
import org.labkey.api.sequenceanalysis.run.SelectVariantsWrapper;
6060
import org.labkey.api.util.FileType;
6161
import org.labkey.api.util.FileUtil;
@@ -77,7 +77,6 @@
7777
import java.util.Arrays;
7878
import java.util.Collection;
7979
import java.util.Collections;
80-
import java.util.Comparator;
8180
import java.util.Date;
8281
import java.util.HashMap;
8382
import java.util.HashSet;
@@ -1024,7 +1023,7 @@ public void processFilesRemote(List<SequenceOutputFile> inputFiles, JobContext c
10241023

10251024
File sitesOnlyVcf = getSitesOnlyVcf(ctx, primaryTrackVcf, genome);
10261025

1027-
File lifted = liftToHuman(ctx, primaryTrackVcf, sitesOnlyVcf, grch37Genome);
1026+
File lifted = liftToHuman(ctx, primaryTrackVcf, sitesOnlyVcf, genome, grch37Genome);
10281027
SequenceOutputFile output3 = new SequenceOutputFile();
10291028
output3.setFile(lifted);
10301029
output3.setName("mGAP Release: " + species + " " + releaseVersion + " Lifted to Human");
@@ -1095,7 +1094,7 @@ private File getSitesOnlyVcf(JobContext ctx, File primaryTrackVcf, ReferenceGeno
10951094
return noGenotypes;
10961095
}
10971096

1098-
private File liftToHuman(JobContext ctx, File primaryTrackVcf, File noGenotypes, ReferenceGenome grch37Genome) throws PipelineJobException
1097+
private File liftToHuman(JobContext ctx, File primaryTrackVcf, File noGenotypes, ReferenceGenome sourceGenome, ReferenceGenome grch37Genome) throws PipelineJobException
10991098
{
11001099
//lift to target genome
11011100
Integer chainFileId = ctx.getSequenceSupport().getCachedObject(AnnotationStep.CHAIN_FILE, Integer.class);
@@ -1108,8 +1107,8 @@ private File liftToHuman(JobContext ctx, File primaryTrackVcf, File noGenotypes,
11081107
File liftoverRejects = new File(ctx.getOutputDir(), SequenceAnalysisService.get().getUnzippedBaseName(primaryTrackVcf.getName()) + ".liftoverRejectGRCh37.vcf.gz");
11091108
if (!indexExists(liftoverRejects))
11101109
{
1111-
LiftoverVcfRunner liftoverVcfRunner = new LiftoverVcfRunner(ctx.getLogger());
1112-
liftoverVcfRunner.doLiftover(noGenotypes, chainFile, grch37Genome.getWorkingFastaFile(), liftoverRejects, liftedToGRCh37, 0.95);
1110+
LiftoverBcfToolsWrapper liftoverVcfRunner = new LiftoverBcfToolsWrapper(ctx.getLogger());
1111+
liftoverVcfRunner.doLiftover(noGenotypes, chainFile, sourceGenome.getWorkingFastaFile(), grch37Genome.getWorkingFastaFile(), liftoverRejects, liftedToGRCh37);
11131112
}
11141113
else
11151114
{

primeseq/src/org/labkey/primeseq/analysis/CombineMethylationRatesHandler.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ public SequenceOutputProcessor getProcessor()
8383
return new Processor();
8484
}
8585

86-
public class Processor implements SequenceOutputProcessor
86+
public static class Processor implements SequenceOutputProcessor
8787
{
8888
@Override
8989
public void processFilesOnWebserver(PipelineJob job, SequenceAnalysisJobSupport support, List<SequenceOutputFile> inputFiles, JSONObject params, File outputDir, List<RecordedAction> actions, List<SequenceOutputFile> outputsToCreate) throws UnsupportedOperationException, PipelineJobException

primeseq/src/org/labkey/primeseq/analysis/MethylationRateComparison.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ public void processFilesOnWebserver(PipelineJob job, SequenceAnalysisJobSupport
172172
Map<String, SequenceOutputFile> fileMap = new HashMap<>();
173173
for (SequenceOutputFile f : inputFiles)
174174
{
175-
action.addInputIfNotPresent(f.getFile(), "Methlylation Rates");
175+
action.addInputIfNotPresent(f.getFile(), "Methylation Rates");
176176
fileMap.put(f.getRowid().toString(), f);
177177
}
178178

0 commit comments

Comments
 (0)