Skip to content

Commit 9f85d3c

Browse files
authored
Add support for mGAP annotations to supply InDefaultFields (#145)
* Add support for mGAP annotations to supply InDefaultFields
1 parent 7f7d5a3 commit 9f85d3c

File tree

8 files changed

+24
-2
lines changed

8 files changed

+24
-2
lines changed
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
ALTER TABLE mGAP.annotations ADD inDefaultColumns boolean;
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
ALTER TABLE mGAP.annotations ADD inDefaultColumns bit;

mGAP/resources/schemas/mgap.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1224,6 +1224,9 @@
12241224
<column columnName="allowableValues">
12251225
<columnTitle>Allowable Values</columnTitle>
12261226
</column>
1227+
<column columnName="inDefaultColumns">
1228+
<columnTitle>In Default Columns?</columnTitle>
1229+
</column>
12271230
<column columnName="container">
12281231
<isHidden>true</isHidden>
12291232
</column>

mGAP/src/org/labkey/mgap/jbrowse/AnnotationModel.java

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ public class AnnotationModel
1717
private String _formatString;
1818
private Boolean _hidden = false;
1919
private Boolean _isIndexed = false;
20+
private Boolean _inDefaultColumns = false;
2021
private String _allowableValues;
2122

2223
public AnnotationModel()
@@ -183,4 +184,14 @@ public void setAllowableValues(String allowableValues)
183184
{
184185
_allowableValues = allowableValues;
185186
}
187+
188+
public Boolean isInDefaultColumns()
189+
{
190+
return _inDefaultColumns;
191+
}
192+
193+
public void setInDefaultColumns(Boolean inDefaultColumns)
194+
{
195+
_inDefaultColumns = inDefaultColumns;
196+
}
186197
}

mGAP/src/org/labkey/mgap/jbrowse/mGAPFieldCustomizer.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,11 @@ else if (ams.size() > 1)
5050
field.setIndexed(true);
5151
}
5252

53+
if (am.isInDefaultColumns())
54+
{
55+
field.setInDefaultColumns(true);
56+
}
57+
5358
if (StringUtils.trimToNull(am.getDescription()) != null)
5459
{
5560
field.setDescription(am.getDescription());

mGAP/src/org/labkey/mgap/mGAPController.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1209,6 +1209,7 @@ public boolean handlePost(Object o, BindException errors) throws Exception
12091209
getOptionalField(line, header, "FormatString", row, "formatString");
12101210
getOptionalField(line, header, "AllowableValues", row, "allowableValues");
12111211
getOptionalField(line, header, "IsIndexed", row, "isIndexed");
1212+
getOptionalField(line, header, "InDefaultColumns", row, "inDefaultColumns");
12121213

12131214
toAdd.add(row);
12141215
}

mGAP/src/org/labkey/mgap/mGAPManager.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ public Set<User> getNotificationUsers()
9999

100100
if (u == null)
101101
{
102-
_log.error("Unknown user registered for mGAP notifcations: " + username);
102+
_log.error("Unknown user registered for mGAP notifications: " + username);
103103
}
104104

105105
if (u != null)

mGAP/src/org/labkey/mgap/mGAPModule.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ public String getName()
7474
@Override
7575
public Double getSchemaVersion()
7676
{
77-
return 16.70;
77+
return 16.71;
7878
}
7979

8080
@Override

0 commit comments

Comments
 (0)