Skip to content

Commit 5c0bb94

Browse files
committed
Improve MCC label format
1 parent 2cb6c78 commit 5c0bb94

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

mcc/src/client/RequestReview/components/RabReviewForm.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -124,8 +124,8 @@ export default function RabReviewForm(props: {requestId: string}) {
124124
<TableRow>
125125
<TableCell>
126126
<FormControl>
127-
<InputLabel id={"review-input-label"}>Enter review...</InputLabel>
128-
<Select id={"review"} variant={"outlined"} name={"review"} aria-label="Review" label={"Review"} error={hasSubmitted && !recordData[0].review} onChange={handleChange} required={true} value={recordData[0].review ?? ''} fullWidth={true} displayEmpty={true}>
127+
<InputLabel id={"review-input-label"}>Review</InputLabel>
128+
<Select id={"review"} variant={"outlined"} name={"review"} aria-label="Review" label={"Review"} labelId={"review-input-label"} error={hasSubmitted && !recordData[0].review} onChange={handleChange} required={true} value={recordData[0].review ?? ''} fullWidth={true} displayEmpty={true}>
129129
<MenuItem value={""}>Not Decided</MenuItem>
130130
<MenuItem value={"I recommend this proposal"}>I recommend this proposal</MenuItem>
131131
<MenuItem value={"I recommend this proposal with conditions"}>I recommend this proposal with conditions</MenuItem>

mcc/src/org/labkey/mcc/MccManager.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,10 +56,10 @@ public enum RequestStatus
5656
Fulfilled(8, "Fulfilled", MccRequestAdminPermission.class),
5757
Withdrawn(9, "Withdrawn", MccRequestorPermission.class);
5858

59-
int sortOrder;
60-
String label;
61-
Class<? extends Permission> updatePermission;
62-
Class<? extends Permission> insertPermission;
59+
final int sortOrder;
60+
final String label;
61+
final Class<? extends Permission> updatePermission;
62+
final Class<? extends Permission> insertPermission;
6363

6464
RequestStatus(int sortOrder, String label, Class<? extends Permission> editPermission)
6565
{

0 commit comments

Comments
 (0)