Skip to content

Commit 4eb5a8e

Browse files
Migrate getSelectSQL callers to SelectBuilder API
QueryService.getSelectSQL() was removed in favor of the getSelectBuilder() fluent API. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 7d8f38d commit 4eb5a8e

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

GenotypeAssays/src/org/labkey/genotypeassays/GeneticsTableCustomizer.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,14 +104,14 @@ private void addAssayFieldsToAnalyses(AbstractTableInfo ti)
104104
AssayProtocolSchema schema = ap.createProtocolSchema(ti.getUserSchema().getUser(), ti.getUserSchema().getContainer(), protocols.get(0), null);
105105
TableInfo data = schema.getTable("data");
106106

107-
SQLFragment selectSql = QueryService.get().getSelectSQL(data, Collections.singleton(data.getColumn("analysisId")), new SimpleFilter(FieldKey.fromString("run/assayType"), GenotypeAssaysManager.SBT_LINEAGE_ASSAY_TYPE), null, 999999, 0, false);
107+
SQLFragment selectSql = QueryService.get().getSelectBuilder(data).columns(Collections.singleton(data.getColumn("analysisId"))).filter(new SimpleFilter(FieldKey.fromString("run/assayType"), GenotypeAssaysManager.SBT_LINEAGE_ASSAY_TYPE)).maxRows(999999).buildSqlFragment();
108108
SQLFragment sql = new SQLFragment("(select count(*) FROM (").append(selectSql).append(") a WHERE a.analysisId = " + ExprColumn.STR_TABLE_ALIAS + ".rowid)");
109109
ExprColumn newCol = new ExprColumn(ti, "numCachedResults", sql, JdbcType.INTEGER, ti.getColumn("rowid"));
110110
newCol.setLabel("# Cached Lineages");
111111
newCol.setURL(DetailsURL.fromString("/query/executeQuery.view?schemaName=assay." + ap.getName().replaceAll(" ", "") + "." + protocols.get(0).getName() + "&query.queryName=data&query.analysisId~eq=${rowid}&query.run/assayType~eq=" + GenotypeAssaysManager.SBT_LINEAGE_ASSAY_TYPE, (ti.getUserSchema().getContainer().isWorkbook() ? ti.getUserSchema().getContainer().getParent() : ti.getUserSchema().getContainer())));
112112
ti.addColumn(newCol);
113113

114-
SQLFragment selectSql2 = QueryService.get().getSelectSQL(data, Collections.singleton(data.getColumn("analysisId")), new SimpleFilter(FieldKey.fromString("run/assayType"), GenotypeAssaysManager.HAPLOTYPE_ASSAY_TYPE), null, 999999, 0, false);
114+
SQLFragment selectSql2 = QueryService.get().getSelectBuilder(data).columns(Collections.singleton(data.getColumn("analysisId"))).filter(new SimpleFilter(FieldKey.fromString("run/assayType"), GenotypeAssaysManager.HAPLOTYPE_ASSAY_TYPE)).maxRows(999999).buildSqlFragment();
115115
SQLFragment sql2 = new SQLFragment("(select count(*) FROM (").append(selectSql2).append(") a WHERE a.analysisId = " + ExprColumn.STR_TABLE_ALIAS + ".rowid)");
116116
ExprColumn newCol2 = new ExprColumn(ti, "numCachedHaplotypes", sql2, JdbcType.INTEGER, ti.getColumn("rowid"));
117117
newCol2.setLabel("# Cached Haplotypes");

tcrdb/src/org/labkey/tcrdb/TCRdbTableCustomizer.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ private void addAssayFieldsToTable(AbstractTableInfo ti, String urlField, String
119119
SimpleFilter filter = new SimpleFilter(FieldKey.fromString("locus"), "None", CompareType.NEQ_OR_NULL);
120120
filter.addCondition(FieldKey.fromString("disabled"), true, CompareType.NEQ_OR_NULL);
121121

122-
SQLFragment selectSql = QueryService.get().getSelectSQL(data, Arrays.asList(data.getColumn("analysisId"), data.getColumn("CDR3"), data.getColumn("locus"), data.getColumn("fraction"), data.getColumn("count"), data.getColumn("cDNA")), filter, null, Table.ALL_ROWS, Table.NO_OFFSET, false);
122+
SQLFragment selectSql = QueryService.get().getSelectBuilder(data).columns(Arrays.asList(data.getColumn("analysisId"), data.getColumn("CDR3"), data.getColumn("locus"), data.getColumn("fraction"), data.getColumn("count"), data.getColumn("cDNA"))).filter(filter).maxRows(Table.ALL_ROWS).buildSqlFragment();
123123
DetailsURL details = DetailsURL.fromString("/query/executeQuery.view?schemaName=assay." + ap.getName().replaceAll(" ", "") + "." + protocols.get(0).getName() + "&query.queryName=data&query." + urlField + "~eq=${" + urlSourceCol + "}", (ti.getUserSchema().getContainer().isWorkbook() ? ti.getUserSchema().getContainer().getParent() : ti.getUserSchema().getContainer()));
124124

125125
SQLFragment sql = new SQLFragment("(select count(*) as expr FROM (").append(selectSql).append(") a ").append(whereClause).append(")");
@@ -173,7 +173,7 @@ private void addAssayFieldsToTable(AbstractTableInfo ti, String urlField, String
173173
if (addRunColumns)
174174
{
175175
TableInfo runs = schema.getTable("runs");
176-
SQLFragment runSelectSql = QueryService.get().getSelectSQL(runs, Collections.singletonList(runs.getColumn("analysisId")), null, null, Table.ALL_ROWS, Table.NO_OFFSET, false);
176+
SQLFragment runSelectSql = QueryService.get().getSelectBuilder(runs).columns(Collections.singletonList(runs.getColumn("analysisId"))).maxRows(Table.ALL_ROWS).buildSqlFragment();
177177
DetailsURL runDetails = DetailsURL.fromString("/query/executeQuery.view?schemaName=assay." + ap.getName().replaceAll(" ", "") + "." + protocols.get(0).getName() + "&query.queryName=runs&query." + urlField + "~eq=${" + urlSourceCol + "}", (ti.getUserSchema().getContainer().isWorkbook() ? ti.getUserSchema().getContainer().getParent() : ti.getUserSchema().getContainer()));
178178

179179
SQLFragment sql5 = new SQLFragment("(select count(*) as expr FROM (").append(runSelectSql).append(") a ").append(whereClause).append(")");
@@ -206,7 +206,7 @@ private void addAssayClonotypeColumn(AbstractTableInfo ti)
206206
SimpleFilter filter = new SimpleFilter(FieldKey.fromString("locus"), "None", CompareType.NEQ_OR_NULL);
207207
filter.addCondition(FieldKey.fromString("disabled"), true, CompareType.NEQ_OR_NULL);
208208

209-
SQLFragment selectSql = QueryService.get().getSelectSQL(ti, Arrays.asList(ti.getColumn("analysisId"), ti.getColumn("cloneId"), ti.getColumn("Run"), ti.getColumn("cDNA"), ti.getColumn("cdr3"), ti.getColumn("locus")), filter, null, Table.ALL_ROWS, Table.NO_OFFSET, false);
209+
SQLFragment selectSql = QueryService.get().getSelectBuilder(ti).columns(Arrays.asList(ti.getColumn("analysisId"), ti.getColumn("cloneId"), ti.getColumn("Run"), ti.getColumn("cDNA"), ti.getColumn("cdr3"), ti.getColumn("locus"))).filter(filter).maxRows(Table.ALL_ROWS).buildSqlFragment();
210210

211211
String whereClause = " WHERE (a.cloneId = " + ExprColumn.STR_TABLE_ALIAS + ".cloneId AND a.analysisId = " + ExprColumn.STR_TABLE_ALIAS + ".analysisId AND a.Run = " + ExprColumn.STR_TABLE_ALIAS + ".Run AND a.cDNA = " + ExprColumn.STR_TABLE_ALIAS + ".cDNA) ";
212212
SQLFragment sql = new SQLFragment("(select ").append(ti.getSqlDialect().getGroupConcat(new SQLFragment(ti.getSqlDialect().concatenate("a.locus", "':'", "a.CDR3")), true, true, getNewlineSql(ti))).append(" FROM (").append(selectSql).append(") a ").append(whereClause).append(" )");
@@ -286,7 +286,7 @@ private void customizeClones(AbstractTableInfo ti)
286286
if (ti.getColumn(colName) == null)
287287
{
288288
TableInfo data = schema.createDataTable(null,false);
289-
SQLFragment dataSelectSql = QueryService.get().getSelectSQL(data, Arrays.asList(data.getColumn("subjectId"), data.getColumn("cdr3"), data.getColumn("fraction")), null, null, Table.ALL_ROWS, Table.NO_OFFSET, false);
289+
SQLFragment dataSelectSql = QueryService.get().getSelectBuilder(data).columns(Arrays.asList(data.getColumn("subjectId"), data.getColumn("cdr3"), data.getColumn("fraction"))).maxRows(Table.ALL_ROWS).buildSqlFragment();
290290

291291
SQLFragment sql = new SQLFragment("(select ").append(ti.getSqlDialect().getGroupConcat(new SQLFragment("a.subjectId"), true, true, getNewlineSql(ti))).append(" as expr FROM (").append(dataSelectSql).append(") a WHERE a.cdr3 = " + ExprColumn.STR_TABLE_ALIAS + ".cdr3 AND a.fraction >= 0.005)");
292292
ExprColumn col = new ExprColumn(ti, colName, sql, JdbcType.VARCHAR, ti.getColumn("cdr3"));

0 commit comments

Comments
 (0)