Skip to content

Commit 2fe8242

Browse files
remove (Integer) casts
bulk search/replace
1 parent fc87f24 commit 2fe8242

File tree

4 files changed

+16
-8
lines changed

4 files changed

+16
-8
lines changed

elispot_assay/src/org/labkey/elispot_assay/assay/DefaultImportMethod.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,8 @@
3232
import java.util.List;
3333
import java.util.Map;
3434

35+
import static org.labkey.api.exp.api.ExperimentService.asInteger;
36+
3537
/**
3638
* Created with IntelliJ IDEA.
3739
* User: bimber
@@ -134,7 +136,7 @@ protected List<Map<String, Object>> calculatePositivity(List<Map<String, Object>
134136

135137
if (TYPE.NEG.getText().equals(row.get(CATEGORY_FIELD)))
136138
{
137-
Integer spots = (Integer)row.get(SPOTS_FIELD);
139+
Integer spots = asInteger(row.get(SPOTS_FIELD));
138140
List<Double> negCtls = negWellMap.get(negCtlKey);
139141
if (negCtls == null)
140142
negCtls = new ArrayList<Double>();
@@ -188,8 +190,8 @@ protected List<Map<String, Object>> calculatePositivity(List<Map<String, Object>
188190
int rowIdx = 0;
189191
for (Map<String, Object> row : rowSet)
190192
{
191-
totalSpots += (Integer)row.get(SPOTS_FIELD);
192-
allSpots[rowIdx] = (Integer)row.get(SPOTS_FIELD);
193+
totalSpots += asInteger(row.get(SPOTS_FIELD));
194+
allSpots[rowIdx] = asInteger(row.get(SPOTS_FIELD));
193195
rowIdx++;
194196
}
195197
Double avgSpots = totalSpots / rowSet.size();
@@ -262,7 +264,7 @@ protected List<Map<String, Object>> calculatePositivity(List<Map<String, Object>
262264
row.put(QCFLAG_FIELD, StringUtils.join(qcflags, "\n"));
263265

264266
//subtract background
265-
Integer spots = (Integer)row.get(SPOTS_FIELD);
267+
Integer spots = asInteger(row.get(SPOTS_FIELD));
266268
Double adj = spots - negCtlSummary.getMean();
267269
List<String> comments = new ArrayList<String>();
268270
if (row.get("comment") != null)

mGAP/src/org/labkey/mgap/mGAPController.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,8 @@
122122
import java.util.zip.ZipEntry;
123123
import java.util.zip.ZipOutputStream;
124124

125+
import static org.labkey.api.exp.api.ExperimentService.asInteger;
126+
125127

126128
public class mGAPController extends SpringActionController
127129
{
@@ -413,7 +415,7 @@ public Object execute(ApproveUserRequestsForm form, BindException errors) throws
413415
User u;
414416
if (map.get("userId") != null)
415417
{
416-
Integer userId = (Integer) map.get("userId");
418+
Integer userId = asInteger(map.get("userId"));
417419
u = UserManager.getUser(userId);
418420
existingUsersGivenAccess.add(u);
419421
}
@@ -556,7 +558,7 @@ else if (!rowContainer.hasPermission(u, ReadPermission.class))
556558

557559
private static SequenceOutputFile getOutputFile(Map<String, Object> row, ReleaseForm form, Errors errors)
558560
{
559-
SequenceOutputFile so = SequenceOutputFile.getForId((Integer) row.get("vcfId"));
561+
SequenceOutputFile so = SequenceOutputFile.getForId(asInteger(row.get("vcfId")));
560562
if (so == null)
561563
{
562564
errors.reject(ERROR_MSG, "Unknown VCF file ID: " + form.getReleaseId());

mcc/src/org/labkey/mcc/MccController.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,8 @@
104104
import java.util.stream.Collectors;
105105
import java.util.stream.IntStream;
106106

107+
import static org.labkey.api.exp.api.ExperimentService.asInteger;
108+
107109
public class MccController extends SpringActionController
108110
{
109111
private static final DefaultActionResolver _actionResolver = new DefaultActionResolver(MccController.class);
@@ -356,7 +358,7 @@ public Object execute(ApproveUserRequestsForm form, BindException errors) throws
356358
User u;
357359
if (map.get("userId") != null)
358360
{
359-
Integer userId = (Integer)map.get("userId");
361+
Integer userId = asInteger(map.get("userId"));
360362
u = UserManager.getUser(userId);
361363
existingUsersGivenAccess.add(u);
362364
}

mcc/src/org/labkey/mcc/query/TriggerHelper.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,8 @@
4949
import java.util.concurrent.atomic.AtomicInteger;
5050
import java.util.stream.Collectors;
5151

52+
import static org.labkey.api.exp.api.ExperimentService.asInteger;
53+
5254
/**
5355
* Created by bimber
5456
*/
@@ -135,7 +137,7 @@ public void ensureReviewRecordsCreated(String objectId, String status, @Nullable
135137
}
136138

137139
Map<String, Object> row = records.get(0);
138-
if (score != (Integer)row.get("preliminaryScore"))
140+
if (score != asInteger(row.get("preliminaryScore")))
139141
{
140142
row.put("preliminaryScore", score);
141143
row.put("modified", new Date());

0 commit comments

Comments
 (0)