review fixes

Author: VisualBean

src/LEGO.AsyncAPI.Readers/AsyncApiDiagnostics.cs

@@ -14,19 +14,16 @@ public class AsyncApiDiagnostic : IDiagnostic
 
         public AsyncApiVersion SpecificationVersion { get; set; }
 
-        public void Append(AsyncApiDiagnostic diagnosticToAdd, string fileNameToAdd = null)
+        public void Append(AsyncApiDiagnostic diagnosticToAdd)
         {
-            var fileNameIsSupplied = !string.IsNullOrEmpty(fileNameToAdd);
             foreach (var error in diagnosticToAdd.Errors)
             {
-                var errMsgWithFileName = fileNameIsSupplied ? $"[File: {fileNameToAdd}] {error.Message}" : error.Message;
-                this.Errors.Add(new(error.Pointer, errMsgWithFileName));
+                this.Errors.Add(new(error.Pointer, error.Message));
             }
 
             foreach (var warning in diagnosticToAdd.Warnings)
             {
-                var warnMsgWithFileName = fileNameIsSupplied ? $"[File: {fileNameToAdd}] {warning.Message}" : warning.Message;
-                this.Warnings.Add(new(warning.Pointer, warnMsgWithFileName));
+                this.Warnings.Add(new(warning.Pointer, warning.Message));
             }
         }
     }

src/LEGO.AsyncAPI.Readers/AsyncApiJsonDocumentReader.cs

@@ -213,7 +213,7 @@ private async Task ResolveReferencesAsync(AsyncApiDiagnostic diagnostic, IAsyncA
                 }
 
                 this.context.Workspace.RegisterComponent(reference.Reference.Reference, component);
-                this.ResolveReferences(diagnostic, component);
+                await this.ResolveReferencesAsync(diagnostic, component);
             }
         }
 
@@ -269,7 +269,7 @@ private IAsyncApiSerializable ResolveExternalReference(AsyncApiDiagnostic diagno
                 throw new ArgumentNullException(nameof(reference));
             }
 
-            var loader = this.settings.ExternalReferenceLoader ??= new DefaultStreamLoader(this.settings);
+            var loader = this.settings.ExternalReferenceLoader ??= new DefaultStreamLoader();
             try
             {
                 Stream stream;
@@ -299,7 +299,7 @@ private async Task<IAsyncApiSerializable> ResolveExternalReferenceAsync(AsyncApi
                 throw new ArgumentNullException(nameof(reference));
             }
 
-            var loader = this.settings.ExternalReferenceLoader ??= new DefaultStreamLoader(this.settings);
+            var loader = this.settings.ExternalReferenceLoader ??= new DefaultStreamLoader();
             try
             {
                 Stream stream;

src/LEGO.AsyncAPI.Readers/Services/DefaultStreamLoader.cs

@@ -12,12 +12,6 @@ namespace LEGO.AsyncAPI.Readers.Services
     internal class DefaultStreamLoader : IStreamLoader
     {
         private static readonly HttpClient HttpClient = new HttpClient();
-        private readonly AsyncApiReaderSettings settings;
-
-        public DefaultStreamLoader(AsyncApiReaderSettings settings)
-        {
-            this.settings = settings;
-        }
 
         public Stream Load(Uri uri)
         {
@@ -27,11 +21,9 @@ public Stream Load(Uri uri)
                 {
                     case "file":
                         return File.OpenRead(uri.AbsolutePath);
-                        break;
                     case "http":
                     case "https":
                         return HttpClient.GetStreamAsync(uri).GetAwaiter().GetResult();
-                        break;
                     default:
                         throw new ArgumentException("Unsupported scheme");
                 }
@@ -51,11 +43,9 @@ public async Task<Stream> LoadAsync(Uri uri)
                 {
                     case "file":
                         return File.OpenRead(uri.AbsolutePath);
-                        break;
                     case "http":
                     case "https":
                         return await HttpClient.GetStreamAsync(uri);
-                        break;
                     default:
                         throw new ArgumentException("Unsupported scheme");
                 }

src/LEGO.AsyncAPI/Models/AsyncApiReference.cs

@@ -14,10 +14,6 @@ public class AsyncApiReference : IAsyncApiSerializable
     {
         private string originalString;
 
-        public AsyncApiReference()
-        {
-        }
-
         public AsyncApiReference(string reference, ReferenceType? type)
         {
             if (string.IsNullOrWhiteSpace(reference))

src/LEGO.AsyncAPI/Models/Avro/AsyncApiAvroSchema.cs

@@ -24,11 +24,12 @@ public static implicit operator AsyncApiAvroSchema(AvroPrimitiveType type)
         public abstract void SerializeV2(IAsyncApiWriter writer);
 
         public virtual bool TryGetAs<T>(out T result)
-where T : AsyncApiAvroSchema
+            where T : AsyncApiAvroSchema
         {
             result = this as T;
             return result != null;
         }
+
         public virtual bool Is<T>()
             where T : AsyncApiAvroSchema
         {