Merge pull request #9 from KristofferStrube/fix/ijsobjectreference-leaks-in-createasync-methods

Fixed that `CreateAsync` methods in `Blob`, `File`, and `FileReader` leaked `IJSObjectReference`s.

Author: KristofferStrube

src/KristofferStrube.Blazor.FileAPI/Blob.cs

@@ -46,7 +46,7 @@ public static Blob Create(IJSRuntime jSRuntime, IJSObjectReference jSReference)
     /// <returns></returns>
     public static async Task<Blob> CreateAsync(IJSRuntime jSRuntime, IList<BlobPart>? blobParts = null, BlobPropertyBag? options = null)
     {
-        IJSObjectReference helper = await jSRuntime.GetHelperAsync();
+        await using IJSObjectReference helper = await jSRuntime.GetHelperAsync();
         object?[]? jsBlobParts = blobParts?.Select<BlobPart, object?>(blobPart => blobPart.Part switch
             {
                 byte[] part => part,
@@ -55,7 +55,7 @@ public static async Task<Blob> CreateAsync(IJSRuntime jSRuntime, IList<BlobPart>
             })
             .ToArray();
         IJSObjectReference jSInstance = await helper.InvokeAsync<IJSObjectReference>("constructBlob", jsBlobParts, options);
-        return new Blob(jSRuntime, jSInstance, new() { DisposesJSReference = true });
+        return new(jSRuntime, jSInstance, new() { DisposesJSReference = true });
     }
 
     /// <inheritdoc cref="CreateAsync(IJSRuntime, IJSObjectReference, CreationOptions)"/>

src/KristofferStrube.Blazor.FileAPI/File.cs

@@ -46,7 +46,7 @@ public class File : Blob, IJSCreatable<File>
     /// <returns></returns>
     public static async Task<File> CreateAsync(IJSRuntime jSRuntime, IList<BlobPart> fileBits, string fileName, FilePropertyBag? options = null)
     {
-        IJSObjectReference helper = await jSRuntime.GetHelperAsync();
+        await using IJSObjectReference helper = await jSRuntime.GetHelperAsync();
         object?[]? jsFileBits = fileBits.Select(blobPart => blobPart.Part switch
             {
                 byte[] part => part,
@@ -55,7 +55,7 @@ public static async Task<File> CreateAsync(IJSRuntime jSRuntime, IList<BlobPart>
             })
             .ToArray();
         IJSObjectReference jSInstance = await helper.InvokeAsync<IJSObjectReference>("constructFile", jsFileBits, fileName, options);
-        return new File(jSRuntime, jSInstance, new() { DisposesJSReference = true });
+        return new(jSRuntime, jSInstance, new() { DisposesJSReference = true });
     }
 
     /// <inheritdoc cref="CreateAsync(IJSRuntime, IJSObjectReference, CreationOptions)"/>

src/KristofferStrube.Blazor.FileAPI/FileReader.cs

@@ -26,7 +26,7 @@ public class FileReader : EventTarget, IJSCreatable<FileReader>
     /// <inheritdoc/>
     public static new async Task<FileReader> CreateAsync(IJSRuntime jSRuntime, IJSObjectReference jSReference, CreationOptions options)
     {
-        IJSObjectReference helper = await jSRuntime.GetHelperAsync();
+        await using IJSObjectReference helper = await jSRuntime.GetHelperAsync();
         FileReader fileReader = new(jSRuntime, jSReference, options);
         await helper.InvokeVoidAsync("registerEventHandlersAsync", DotNetObjectReference.Create(fileReader), jSReference);
         return fileReader;
@@ -39,7 +39,7 @@ public class FileReader : EventTarget, IJSCreatable<FileReader>
     /// <returns>A wrapper instance for a <see cref="FileReader"/>.</returns>
     public static new async Task<FileReader> CreateAsync(IJSRuntime jSRuntime)
     {
-        IJSObjectReference helper = await jSRuntime.GetHelperAsync();
+        await using IJSObjectReference helper = await jSRuntime.GetHelperAsync();
         IJSObjectReference jSInstance = await helper.InvokeAsync<IJSObjectReference>("constructFileReader");
         FileReader fileReader = new(jSRuntime, jSInstance, new() { DisposesJSReference = true });
         await helper.InvokeVoidAsync("registerEventHandlersAsync", DotNetObjectReference.Create(fileReader), jSInstance);