Skip to content

Commit 5698a63

Browse files
authored
EventViewer: Cleanup sigs properly and close dialog properly
1 parent 37ed92d commit 5698a63

File tree

1 file changed

+11
-7
lines changed

1 file changed

+11
-7
lines changed

plugindevtools/PluginDevTools/PluginDevToolsDocker.py

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1856,10 +1856,14 @@ def __init__(self, caller):
18561856
self.centralWidget.clearBtn.clicked.connect(self.listenTreeModel.clear)
18571857
self.centralWidget.eventCodeBtn.clicked.connect(self.updateCode)
18581858

1859+
1860+
18591861

1860-
def closeEvent(self, event):
1862+
def hideEvent(self, event):
18611863
self.stop()
1862-
super().closeEvent(event)
1864+
super().hideEvent(event)
1865+
1866+
18631867

18641868
def updateCode(self):
18651869
content = self.centralWidget.eventCodeTextEdit.toPlainText()
@@ -2059,11 +2063,11 @@ def stop(self):
20592063
qApp.removeEventFilter(self)
20602064

20612065

2062-
for methName in self.signalsDict['current']:
2063-
if not sip.isdeleted(self.signalsDict['current'][methName]['obj']):
2064-
meth = getattr(self.signalsDict['current'][methName]['obj'],methName)
2065-
if isinstance(meth,type(pyqtBoundSignal())) or isinstance(meth,type(pyqtSignal())):
2066-
meth.disconnect(self.signalsDict['current'][methName]['method'])
2066+
for methName in self.signalsDict['current']:
2067+
if not sip.isdeleted(self.signalsDict['current'][methName]['obj']):
2068+
meth = getattr(self.signalsDict['current'][methName]['obj'],methName)
2069+
if isinstance(meth,type(pyqtBoundSignal())) or isinstance(meth,type(pyqtSignal())):
2070+
meth.disconnect(self.signalsDict['current'][methName]['method'])
20672071

20682072
if self.centralWidget.outputCmb.currentIndex() == 1:
20692073
sys.stdout = self.oldSTDOUT

0 commit comments

Comments
 (0)