From 23da93bf3a1c5b47ea7112db40796701b2fd5071 Mon Sep 17 00:00:00 2001 From: Tim Carr Date: Thu, 27 Nov 2025 15:04:56 +0800 Subject: [PATCH 1/2] Return `refresh()` result --- src/class-convertkit-resource-v4.php | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/class-convertkit-resource-v4.php b/src/class-convertkit-resource-v4.php index f3caf08..440ce23 100644 --- a/src/class-convertkit-resource-v4.php +++ b/src/class-convertkit-resource-v4.php @@ -116,14 +116,12 @@ public function init() { // a last query time. This handles upgrades from < 1.9.7.4 where resources // would never expire. if ( ! $this->last_queried ) { - $this->refresh(); - return; + return $this->refresh(); } // If the resources have expired, refresh them now. if ( time() > ( $this->last_queried + $this->cache_duration ) ) { - $this->refresh(); - return; + return $this->refresh(); } } @@ -344,13 +342,13 @@ public function exist() { * * @since 1.0.0 * - * @return bool|WP_Error|array + * @return WP_Error|array */ public function refresh() { // Bail if no API class was defined. if ( ! $this->api ) { - return false; + return new WP_Error( 'convertkit_resource_refresh_error', 'Connect the plugin to your ConvertKit account to refresh resources.' ); } // Fetch resources. From 7efefe12dcacace21d679787c70e9836300f0982 Mon Sep 17 00:00:00 2001 From: Tim Carr Date: Thu, 27 Nov 2025 16:36:23 +0800 Subject: [PATCH 2/2] Update refresh() error message --- src/class-convertkit-resource-v4.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/class-convertkit-resource-v4.php b/src/class-convertkit-resource-v4.php index 440ce23..60f9da0 100644 --- a/src/class-convertkit-resource-v4.php +++ b/src/class-convertkit-resource-v4.php @@ -348,7 +348,7 @@ public function refresh() { // Bail if no API class was defined. if ( ! $this->api ) { - return new WP_Error( 'convertkit_resource_refresh_error', 'Connect the plugin to your ConvertKit account to refresh resources.' ); + return new WP_Error( 'convertkit_resource_refresh_error', 'Connect the Plugin to your Kit account to refresh resources.' ); } // Fetch resources.