layers: Use ostringstream over stringstream (#11344)

Author: spencer-lunarg

layers/best_practices/bp_descriptor.cpp

@@ -171,7 +171,7 @@ bool BestPractices::PreCallValidateCreateDescriptorPool(VkDevice device, const V
 
     const auto* mutable_descriptor_type_ci = vku::FindStructInPNextChain<VkMutableDescriptorTypeCreateInfoEXT>(pCreateInfo->pNext);
     if (mutable_descriptor_type_ci && mutable_descriptor_type_ci->mutableDescriptorTypeListCount > pCreateInfo->poolSizeCount) {
-        std::stringstream msg;
+        std::ostringstream msg;
         if (pCreateInfo->poolSizeCount == 1) {
             msg << "first element";
         } else {

layers/best_practices/bp_utils.cpp

@@ -50,7 +50,7 @@ const char* VendorSpecificTag(BPVendorFlags vendors) {
     auto res = tag_map.find(vendors);
     if (res == tag_map.end()) {
         // Build the vendor tag string
-        std::stringstream vendor_tag;
+        std::ostringstream vendor_tag;
 
         vendor_tag << "[";
         bool first_vendor = true;

layers/containers/range.h

@@ -126,14 +126,14 @@ class range_view {
 
 template <typename Range>
 std::string string_range(const Range &range) {
-    std::stringstream ss;
+    std::ostringstream ss;
     ss << "[" << range.begin << ", " << range.end << ')';
     return ss.str();
 }
 
 template <typename Range>
 std::string string_range_hex(const Range &range) {
-    std::stringstream ss;
+    std::ostringstream ss;
     ss << std::hex << "[0x" << range.begin << ", 0x" << range.end << ')';
     return ss.str();
 }

layers/core_checks/cc_buffer.cpp

@@ -269,7 +269,7 @@ bool CoreChecks::PreCallValidateCreateBufferView(VkDevice device, const VkBuffer
                 alignment_requirement = std::min(alignment_requirement, texel_block_size);
             }
             if (!IsIntegerMultipleOf(pCreateInfo->offset, alignment_requirement)) {
-                std::stringstream ss;
+                std::ostringstream ss;
                 ss << "was created with VK_BUFFER_USAGE_2_STORAGE_TEXEL_BUFFER_BIT, so the offset (" << pCreateInfo->offset
                    << ") must be a multiple of " << alignment_requirement << "\n";
                 if (phys_dev_props_core13.storageTexelBufferOffsetSingleTexelAlignment) {
@@ -297,7 +297,7 @@ bool CoreChecks::PreCallValidateCreateBufferView(VkDevice device, const VkBuffer
                 alignment_requirement = std::min(alignment_requirement, texel_block_size);
             }
             if (!IsIntegerMultipleOf(pCreateInfo->offset, alignment_requirement)) {
-                std::stringstream ss;
+                std::ostringstream ss;
                 ss << "was created with VK_BUFFER_USAGE_2_UNIFORM_TEXEL_BUFFER_BIT, so the offset (" << pCreateInfo->offset
                    << ") must be a multiple of " << alignment_requirement << "\n";
                 if (phys_dev_props_core13.uniformTexelBufferOffsetSingleTexelAlignment) {

layers/core_checks/cc_buffer_address.h

@@ -100,7 +100,7 @@ class BufferAddressValidation {
         vvl::span<vvl::Buffer* const> buffer_list = validator.GetBuffersByAddress(device_address);
         if (buffer_list.empty()) {
             NearestBufferResult nearest = validator.GetNearestBuffersByAddress(device_address);
-            std::stringstream ss;
+            std::ostringstream ss;
             ss << "(0x" << std::hex << device_address
                << ") is not a valid buffer address. No call to vkGetBufferDeviceAddress has this buffer in its range.";
             if (!nearest.above_buffers.empty()) {
@@ -196,7 +196,7 @@ bool BufferAddressValidation<ChecksCount>::LogInvalidBuffers(const CoreChecks& v
     // Some checks only care about the address, but for those that have a range, print it here so it is the same across all error
     // messages
     if (range_size != 0) {
-        std::stringstream ss;
+        std::ostringstream ss;
         ss << "[0x" << std::hex << device_address << ", 0x" << (device_address + range_size) << ") (";
         if (range_size == VK_WHOLE_SIZE) {
             ss << "VK_WHOLE_SIZE";
@@ -213,7 +213,7 @@ bool BufferAddressValidation<ChecksCount>::LogInvalidBuffers(const CoreChecks& v
         }
         error_msg_beginning = ss.str();
     } else {
-        std::stringstream ss;
+        std::ostringstream ss;
         ss << "(0x" << std::hex << device_address << ") has no buffer(s) associated that are valid.\n";
         error_msg_beginning = ss.str();
     }

layers/core_checks/cc_cmd_buffer.cpp

@@ -108,7 +108,7 @@ bool CoreChecks::ValidateCmd(const vvl::CommandBuffer &cb_state, const Location
 
 // This is a single location to report when a command buffer is invalid (which means it is not in a "recording state")
 bool CoreChecks::ReportInvalidCommandBuffer(const vvl::CommandBuffer &cb_state, const Location &loc, const char *vuid) const {
-    std::stringstream ss;
+    std::ostringstream ss;
     ss << "was called in " << FormatHandle(cb_state) << " which ";
 
     assert(cb_state.state == CbState::InvalidIncomplete || cb_state.state == CbState::InvalidComplete);
@@ -966,7 +966,7 @@ class CoreChecks::ViewportScissorInheritanceTracker {
                     break;
             }
 
-            std::stringstream ss;
+            std::ostringstream ss;
             ss << "(" << log_.FormatHandle(secondary_state.Handle()).c_str() << ") consume inherited " << state_name << " ";
             if (format_index) {
                 if (index >= static_use_count) {

layers/core_checks/cc_cmd_buffer_dynamic.cpp

@@ -1340,7 +1340,7 @@ bool CoreChecks::ValidateDrawRenderingAttachmentLocation(const vvl::CommandBuffe
         uint32_t pipeline_color_location = pipeline_color_locations ? pipeline_color_locations[i] : i;
         if (pipeline_color_location != cb_state.rendering_attachments.color_locations[i]) {
             const LogObjectList objlist(cb_state.Handle(), pipeline_state.Handle());
-            std::stringstream ss;
+            std::ostringstream ss;
             ss << "The pipeline VkRenderingAttachmentLocationInfo::pColorAttachmentLocations[" << i << "] is "
                << pipeline_color_location;
             if (!explicit_pipeline) {
@@ -1395,7 +1395,7 @@ bool CoreChecks::ValidateDrawRenderingInputAttachmentIndex(const vvl::CommandBuf
         uint32_t pipeline_color_index = pipeline_color_indexes ? pipeline_color_indexes[i] : i;
         if (pipeline_color_index != cb_state.rendering_attachments.color_indexes[i]) {
             const LogObjectList objlist(cb_state.Handle(), pipeline_state.Handle());
-            std::stringstream ss;
+            std::ostringstream ss;
             ss << "The pipeline VkRenderingInputAttachmentIndexInfo::pColorAttachmentInputIndices[" << i << "] is "
                << pipeline_color_index;
             if (!explicit_pipeline) {
@@ -1414,7 +1414,7 @@ bool CoreChecks::ValidateDrawRenderingInputAttachmentIndex(const vvl::CommandBuf
 
     if (!EqualValuesOrBothNull(pipeline_depth_index, cb_state.rendering_attachments.depth_index)) {
         const LogObjectList objlist(cb_state.Handle(), pipeline_state.Handle());
-        std::stringstream ss;
+        std::ostringstream ss;
         ss << "The pipeline VkRenderingInputAttachmentIndexInfo::pDepthInputAttachmentIndex is "
            << string_AttachmentPointer(pipeline_depth_index);
         if (!explicit_pipeline) {
@@ -1431,7 +1431,7 @@ bool CoreChecks::ValidateDrawRenderingInputAttachmentIndex(const vvl::CommandBuf
 
     if (!EqualValuesOrBothNull(pipeline_stencil_index, cb_state.rendering_attachments.stencil_index)) {
         const LogObjectList objlist(cb_state.Handle(), pipeline_state.Handle());
-        std::stringstream ss;
+        std::ostringstream ss;
         ss << "The pipeline VkRenderingInputAttachmentIndexInfo::pStencilInputAttachmentIndex is "
            << string_AttachmentPointer(pipeline_stencil_index);
         if (!explicit_pipeline) {

layers/core_checks/cc_copy_blit_resolve.cpp

@@ -45,7 +45,7 @@ struct ImageRegionIntersection {
     VkExtent3D extent = {1, 1, 1};
     bool has_intersection = false;
     std::string String() const noexcept {
-        std::stringstream ss;
+        std::ostringstream ss;
         ss << "\nsubresource : { aspectMask: " << string_VkImageAspectFlags(subresource.aspectMask)
            << ", mipLevel: " << subresource.mipLevel << ", baseArrayLayer: " << subresource.baseArrayLayer
            << ", layerCount: " << subresource.layerCount << " },\noffset : {" << string_VkOffset3D(offset) << "},\nextent : {"
@@ -272,7 +272,7 @@ bool CoreChecks::ValidateTransferGranularityExtent(const LogObjectList &objlist,
         }
 
         if (!(x_ok && y_ok && z_ok)) {
-            std::stringstream ss;
+            std::ostringstream ss;
             ss << "(" << string_VkExtent3D(region_extent)
                << ") is invalid with this command buffer's queue family minImageTransferGranularity ("
                << string_VkExtent3D(granularity) << ") for copying to/from " << FormatHandle(image_state) << " ("
@@ -330,7 +330,7 @@ static std::string DescribeValidAspectMaskForFormat(VkFormat format) {
         aspect_mask |= VK_IMAGE_ASPECT_PLANE_2_BIT;
     }
 
-    std::stringstream ss;
+    std::ostringstream ss;
     ss << "Valid VkImageAspectFlags are " << string_VkImageAspectFlags(aspect_mask);
     return ss.str();
 }
@@ -421,14 +421,14 @@ struct ImageCopyRegion {
     }
 
     std::string DescribeSrcAndDstImage() const {
-        std::stringstream ss;
+        std::ostringstream ss;
         ss << "srcImage: " << src_state.DescribeSubresourceLayers(src_subresource)
            << "dstImage: " << dst_state.DescribeSubresourceLayers(dst_subresource);
         return ss.str();
     }
 
     std::string DescribeAdjustedExtent() const {
-        std::stringstream ss;
+        std::ostringstream ss;
         if (is_adjusted_extent) {
             ss << "The VkImageCopy::extent [" << string_VkExtent3D(extent) << "] is adjusted to ["
                << string_VkExtent3D(dst_adjusted_extent) << "] because it is going from ";
@@ -1536,7 +1536,7 @@ bool CoreChecks::ValidateCmdCopyImage(VkCommandBuffer commandBuffer, VkImage src
                 const bool exception = src_image_type != dst_image_type && src_layer_count == VK_REMAINING_ARRAY_LAYERS &&
                                        dst_layer_count == VK_REMAINING_ARRAY_LAYERS;
                 if (!exception && normalized_src_layer_count != normalized_dst_layer_count) {
-                    std::stringstream ss;
+                    std::ostringstream ss;
                     ss << "(" << string_LayerCount(src_image_state->create_info, src_subresource) << ") does not match "
                        << dst_subresource_loc.dot(Field::layerCount).Fields() << " ("
                        << string_LayerCount(dst_image_state->create_info, dst_subresource) << ").";
@@ -1685,7 +1685,7 @@ bool CoreChecks::ValidateCmdCopyImage(VkCommandBuffer commandBuffer, VkImage src
             // If size is still zero, then format is invalid and will be caught in another VU
             if ((src_format_size != dst_format_size) && (src_format_size != 0) && (dst_format_size != 0)) {
                 vuid = is_2 ? "VUID-VkCopyImageInfo2-None-01549" : "VUID-vkCmdCopyImage-None-01549";
-                std::stringstream ss;
+                std::ostringstream ss;
                 ss << "srcImage format " << string_VkFormat(src_plane_format);
                 if (is_src_multiplane) {
                     ss << " (which is the compatible format for plane "
@@ -2131,7 +2131,7 @@ bool CoreChecks::ValidateBufferBounds(const vvl::CommandBuffer &cb_state, const
 
     if (buffer_state.create_info.size < buffer_copy_size) {
         const LogObjectList objlist(cb_state.Handle(), buffer_state.Handle(), image_state.Handle());
-        std::stringstream ss;
+        std::ostringstream ss;
         ss << "is trying to copy " << buffer_copy_size << " bytes to/from the (" << FormatHandle(buffer_state).c_str()
            << ") which exceeds the VkBuffer total size of " << buffer_state.create_info.size
            << " bytes.\nLast texel coordinate of the image is at {x = " << last_x << ", y = " << last_y << ", z = " << last_z
@@ -2678,7 +2678,7 @@ bool CoreChecks::ValidateMemoryImageCopyCommon(InfoPointer info_ptr, const Locat
 bool CoreChecks::ValidateHostCopyImageCreateInfos(const vvl::Image &src_image_state, const vvl::Image &dst_image_state,
                                                   const Location &loc) const {
     bool skip = false;
-    std::stringstream mismatch_stream{};
+    std::ostringstream mismatch_stream{};
     const VkImageCreateInfo &src_info = src_image_state.create_info;
     const VkImageCreateInfo &dst_info = dst_image_state.create_info;
 
@@ -2729,7 +2729,7 @@ bool CoreChecks::ValidateHostCopyImageCreateInfos(const vvl::Image &src_image_st
     }
 
     if (mismatch_stream.str().length() > 0) {
-        std::stringstream ss;
+        std::ostringstream ss;
         ss << "The creation parameters for srcImage and dstImage differ:\n" << mismatch_stream.str();
         LogObjectList objlist(src_image_state.Handle(), dst_image_state.Handle());
         skip |= LogError("VUID-VkCopyImageToImageInfo-srcImage-09069", objlist, loc, "%s.", ss.str().c_str());
@@ -2751,7 +2751,7 @@ bool CoreChecks::ValidateHostCopyImageLayout(const VkImage image, const VkImageL
         }
     }
 
-    std::stringstream ss;
+    std::ostringstream ss;
     ss << "is " << string_VkImageLayout(image_layout)
        << " which is not one of the layouts returned in VkPhysicalDeviceHostImageCopyPropertiesEXT::" << String(supported_name)
        << "[" << layout_count << "]\nList of supported layouts:\n";

layers/core_checks/cc_descriptor.cpp

@@ -71,7 +71,7 @@ bool CoreChecks::VerifyDescriptorSetLayoutIsCompatibile(const vvl::DescriptorSet
     // Check descriptor counts
     const auto bound_total_count = to_bind_ds_layout_def->GetTotalDescriptorCount();
     if (reference_ds_layout_def->GetTotalDescriptorCount() != to_bind_ds_layout_def->GetTotalDescriptorCount()) {
-        std::stringstream error_str;
+        std::ostringstream error_str;
         error_str << FormatHandle(reference_dsl_handle) << " from pipeline layout has "
                   << reference_ds_layout_def->GetTotalDescriptorCount() << " total descriptors, but "
                   << FormatHandle(to_bind_dsl_handle) << ", trying to bind, has " << bound_total_count << " total descriptors";
@@ -84,7 +84,7 @@ bool CoreChecks::VerifyDescriptorSetLayoutIsCompatibile(const vvl::DescriptorSet
     for (const auto [binding_index, layout_binding] : vvl::enumerate(reference_ds_layout_def->GetBindings())) {
         const auto bound_binding = to_bind_ds_layout_def->GetBindingInfoFromIndex((uint32_t)binding_index);
         if (layout_binding.descriptorCount != bound_binding->descriptorCount) {
-            std::stringstream error_str;
+            std::ostringstream error_str;
             error_str << "Binding " << layout_binding.binding << " for " << FormatHandle(reference_dsl_handle)
                       << " from pipeline layout has a descriptorCount of " << layout_binding.descriptorCount << " but binding "
                       << layout_binding.binding << " for " << FormatHandle(to_bind_dsl_handle)
@@ -96,15 +96,15 @@ bool CoreChecks::VerifyDescriptorSetLayoutIsCompatibile(const vvl::DescriptorSet
             error_msg = error_str.str();
             return false;
         } else if (layout_binding.descriptorType != bound_binding->descriptorType) {
-            std::stringstream error_str;
+            std::ostringstream error_str;
             error_str << "Binding " << layout_binding.binding << " for " << FormatHandle(reference_dsl_handle)
                       << " from pipeline layout is type " << string_VkDescriptorType(layout_binding.descriptorType)
                       << " but binding " << layout_binding.binding << " for " << FormatHandle(to_bind_dsl_handle)
                       << ", trying to bind, is type " << string_VkDescriptorType(bound_binding->descriptorType) << "";
             error_msg = error_str.str();
             return false;
         } else if (layout_binding.stageFlags != bound_binding->stageFlags) {
-            std::stringstream error_str;
+            std::ostringstream error_str;
             error_str << "Binding " << layout_binding.binding << " for " << FormatHandle(reference_dsl_handle)
                       << " from pipeline layout has stageFlags " << string_VkShaderStageFlags(layout_binding.stageFlags)
                       << " but binding " << layout_binding.binding << " for " << FormatHandle(to_bind_dsl_handle)
@@ -121,7 +121,7 @@ bool CoreChecks::VerifyDescriptorSetLayoutIsCompatibile(const vvl::DescriptorSet
     }
 
     if (reference_ds_layout_def->GetCreateFlags() != to_bind_ds_layout_def->GetCreateFlags()) {
-        std::stringstream error_str;
+        std::ostringstream error_str;
         error_str << FormatHandle(reference_dsl_handle) << " from pipeline layout was created with ("
                   << string_VkDescriptorSetLayoutCreateFlags(reference_ds_layout_def->GetCreateFlags()) << "), but "
                   << FormatHandle(to_bind_dsl_handle) << ", trying to bind, has ("
@@ -134,7 +134,7 @@ bool CoreChecks::VerifyDescriptorSetLayoutIsCompatibile(const vvl::DescriptorSet
     const auto &ds_layout_flags = reference_ds_layout_def->GetBindingFlags();
     const auto &bound_layout_flags = to_bind_ds_layout_def->GetBindingFlags();
     if (bound_layout_flags != ds_layout_flags) {
-        std::stringstream error_str;
+        std::ostringstream error_str;
         assert(ds_layout_flags.size() == bound_layout_flags.size());
         size_t i;
         for (i = 0; i < ds_layout_flags.size(); i++) {
@@ -1416,7 +1416,7 @@ bool CoreChecks::ValidateImageUpdate(const vvl::ImageView &view_state, VkImageLa
                 default:
                     break;
             }
-            std::stringstream error_str;
+            std::ostringstream error_str;
             error_str << "Descriptor update with descriptorType " << string_VkDescriptorType(type)
                       << " is being updated with invalid imageLayout " << string_VkImageLayout(image_layout) << " for image "
                       << FormatHandle(image_state->Handle()) << " in imageView " << FormatHandle(view_state.Handle())
@@ -1790,7 +1790,7 @@ bool CoreChecks::ValidateWriteUpdate(const vvl::DescriptorSet &dst_set, const Vk
             // stageFlags
             if (current_binding->count > 0) {
                 if (current_binding->type != descriptor_type) {
-                    std::stringstream extra;
+                    std::ostringstream extra;
                     // If using inline, easy to go outside of its range and not realize you are in the next descriptor
                     if (descriptor_type == VK_DESCRIPTOR_TYPE_INLINE_UNIFORM_BLOCK) {
                         extra << "\nFor inline uniforms blocks, you might have your VkWriteDescriptorSet::dstArrayElement ("
@@ -2826,7 +2826,7 @@ bool CoreChecks::PreCallValidateCmdBindDescriptorBuffersEXT(VkCommandBuffer comm
 
     auto list_buffers = [this](std::vector<VkBuffer> &buffer_list) {
         vvl::unordered_set<VkBuffer> unique_buffers;
-        std::stringstream msg;
+        std::ostringstream msg;
         for (const VkBuffer &buffer : buffer_list) {
             msg << FormatHandle(buffer) << '\n';
             unique_buffers.insert(buffer);
@@ -3234,7 +3234,7 @@ bool CoreChecks::ValidateDescriptorAddressInfoTexelBufferAlignment(const VkDescr
             alignment_requirement = std::min(alignment_requirement, texel_block_size);
         }
         if (!IsPointerAligned(address_info.address, alignment_requirement)) {
-            std::stringstream ss;
+            std::ostringstream ss;
             ss << "(0x" << std::hex << address_info.address << std::dec << ") must be aligned to " << alignment_requirement << "\n";
             if (phys_dev_props_core13.storageTexelBufferOffsetSingleTexelAlignment) {
                 ss << "storageTexelBufferOffsetSingleTexelAlignment is VK_TRUE, so we take "
@@ -3260,7 +3260,7 @@ bool CoreChecks::ValidateDescriptorAddressInfoTexelBufferAlignment(const VkDescr
             alignment_requirement = std::min(alignment_requirement, texel_block_size);
         }
         if (!IsPointerAligned(address_info.address, alignment_requirement)) {
-            std::stringstream ss;
+            std::ostringstream ss;
             ss << "(0x" << std::hex << address_info.address << std::dec << ") must be a aligned to " << alignment_requirement
                << "\n";
             if (phys_dev_props_core13.uniformTexelBufferOffsetSingleTexelAlignment) {