Skip to content

Commit f420a26

Browse files
committed
Database: fix open mysql database bug
1 parent 74acd42 commit f420a26

2 files changed

Lines changed: 14 additions & 6 deletions

File tree

Src/Database/Database.cpp

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -139,6 +139,7 @@ bool CDatabase::OpenSQLiteDatabase(const CParameterDatabase *pPara,
139139
bool CDatabase::OpenMySqlDatabase(const CParameterDatabase *pPara,
140140
const QString &szConnectName)
141141
{
142+
bool success = false;
142143
if(!pPara) return false;
143144

144145
if(!szConnectName.isEmpty())
@@ -154,7 +155,7 @@ bool CDatabase::OpenMySqlDatabase(const CParameterDatabase *pPara,
154155
szDbName = "remote_control";
155156
#endif
156157
}
157-
m_database.setDatabaseName(szDbName);
158+
158159
auto &net = pPara->m_Net;
159160
m_database.setHostName(net.GetHost());
160161
m_database.setPort(net.GetPort());
@@ -173,7 +174,7 @@ bool CDatabase::OpenMySqlDatabase(const CParameterDatabase *pPara,
173174
}
174175

175176
QSqlQuery query(GetDatabase());
176-
bool success = query.exec("CREATE DATABASE IF NOT EXISTS " + szDbName);
177+
success = query.exec("CREATE DATABASE IF NOT EXISTS " + szDbName);
177178
if (!success) {
178179
qCritical(log) << "Failed to create" << szDbName << "database:"
179180
<< query.lastError().text()
@@ -189,8 +190,11 @@ bool CDatabase::OpenMySqlDatabase(const CParameterDatabase *pPara,
189190
return false;
190191
}
191192

193+
m_database.setDatabaseName(szDbName);
192194
qInfo(log) << "Open mysql database connect:"
193195
<< m_database.connectionName()
196+
<< "Host:" << net.GetHost() << "Port:" << net.GetPort()
197+
<< "User:" << user.GetUser()
194198
<< "database name:" << m_database.databaseName();
195199

196200
return OnInitializeDatabase();

Src/ParameterCompone/ParameterPlugin.cpp

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -85,11 +85,15 @@ int CParameterPlugin::OnLoad(QSettings &set)
8585
SetPluginsPath(set.value("Paths", GetPluginsPath()).toStringList());
8686
SetEnableSetPluginsPath(set.value("Paths/Enable", GetEnableSetPluginsPath()).toBool());
8787
SetOnlyLoadInWhitelist(set.value("OnlyLoadInWhitelist", GetOnlyLoadInWhitelist()).toBool());
88-
89-
set.endGroup();
9088

91-
m_WhiteList.InitDatabase(&m_pGlobalParameter->m_Database);
92-
m_BlackList.InitDatabase(&m_pGlobalParameter->m_Database);
89+
set.endGroup();
90+
91+
// Only in local database
92+
CParameterDatabase db;
93+
db = m_pGlobalParameter->m_Database;
94+
db.SetType("QSQLITE");
95+
m_WhiteList.InitDatabase(&db);
96+
m_BlackList.InitDatabase(&db);
9397
return 0;
9498
}
9599

0 commit comments

Comments
 (0)