From d08c577b3d03da43689b0f18bd0ffe6c5c3a3f38 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bernhard=20K=C3=B6nig?= Date: Wed, 4 Jun 2025 12:05:57 +0200 Subject: [PATCH 1/4] add test for Random --- Project.toml | 2 ++ src/MySQL.jl | 1 + test/runtests.jl | 4 ++++ 3 files changed, 7 insertions(+) diff --git a/Project.toml b/Project.toml index 56644cf..7937c20 100644 --- a/Project.toml +++ b/Project.toml @@ -10,6 +10,7 @@ DecFP = "55939f99-70c6-5e9b-8bb0-5071ed7d61fd" Libdl = "8f399da3-3557-5675-b5ff-fb832c97cbdb" MariaDB_Connector_C_jll = "aabc7e14-95f1-5e66-9f32-aea603782360" Parsers = "69de0a69-1ddd-5017-9359-2bf0b02dc9f0" +Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c" Tables = "bd369af6-aec1-5ad0-b16a-f7cc5008161c" [compat] @@ -17,6 +18,7 @@ DBInterface = "2.5" DecFP = "0.4.9, 0.4.10, 1" MariaDB_Connector_C_jll = "3.1.12" Parsers = "0.3, 1, 2" +Random = "1.11.0" Tables = "1" julia = "1.6" diff --git a/src/MySQL.jl b/src/MySQL.jl index 8c2ccf6..18397e1 100644 --- a/src/MySQL.jl +++ b/src/MySQL.jl @@ -2,6 +2,7 @@ module MySQL using Dates, DBInterface, Tables, Parsers, DecFP import DBInterface: transaction +import Random export DBInterface, DateAndTime diff --git a/test/runtests.jl b/test/runtests.jl index bfd18b2..18eeb00 100644 --- a/test/runtests.jl +++ b/test/runtests.jl @@ -156,6 +156,10 @@ for nm in keys(res) @test isequal(res[nm], expected[nm][1:4]) end +#https://github.com/JuliaDatabases/MySQL.jl/issues/226 +ct0 = (x = UInt8[1, 22, 23],) +MySQL.load(ct0,conn, debug=true) +#there is no @test invocation here; but the above call failed due to Random not being imported # now test insert/parameter binding DBInterface.execute(conn, "DELETE FROM Employee") From 6f7e54944d9f5659566151056610f90ac0f963dd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bernhard=20K=C3=B6nig?= Date: Wed, 4 Jun 2025 12:58:21 +0200 Subject: [PATCH 2/4] setup-julia v2 --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f842303..7522505 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -22,7 +22,7 @@ jobs: steps: - uses: actions/checkout@v2 - run: docker compose up -d - - uses: julia-actions/setup-julia@v1 + - uses: julia-actions/setup-julia@v2 with: version: ${{ matrix.version }} arch: ${{ matrix.arch }} From 5c449e9f7bfdcb7a59257b45e56f9c47eec533d1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bernhard=20K=C3=B6nig?= Date: Wed, 4 Jun 2025 12:59:55 +0200 Subject: [PATCH 3/4] upgarde cache to v4 --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 7522505..9876a70 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -26,7 +26,7 @@ jobs: with: version: ${{ matrix.version }} arch: ${{ matrix.arch }} - - uses: actions/cache@v1 + - uses: actions/cache@v4 env: cache-name: cache-artifacts with: From 4b3e46626d20c7882a82f290ad7c6300afade8d0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bernhard=20K=C3=B6nig?= Date: Wed, 4 Jun 2025 13:06:22 +0200 Subject: [PATCH 4/4] re trigger CI --- test/runtests.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/runtests.jl b/test/runtests.jl index 18eeb00..344844e 100644 --- a/test/runtests.jl +++ b/test/runtests.jl @@ -303,7 +303,7 @@ res, st = state ret = columntable(res) @test length(ret[1]) == 5 state = iterate(results, st) -@test state !== nothing +@test state !== nothing res, st = state @test !st @test length(res) == 4