Skip to content

Commit ea5cbec

Browse files
committed
Removed debug mode, added logger
1 parent a3a455f commit ea5cbec

File tree

5 files changed

+12
-24
lines changed

5 files changed

+12
-24
lines changed

src/main/java/org/javawebstack/orm/ORM.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,12 @@
88
import java.util.HashMap;
99
import java.util.List;
1010
import java.util.Map;
11+
import java.util.logging.Logger;
1112

1213
public class ORM {
1314

15+
public static final Logger LOGGER = Logger.getLogger("ORM");
16+
1417
private static final Map<Class<? extends Model>, Repo<?>> repositories = new HashMap<>();
1518

1619
public static <T extends Model> Repo<T> repo(Class<T> model){

src/main/java/org/javawebstack/orm/ORMConfig.java

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,7 @@ public class ORMConfig {
1111
private boolean camelToSnakeCase = true;
1212
private int defaultSize = 0;
1313
private boolean idPrimaryKey = true;
14-
private List<TypeMapper> typeMappers = new ArrayList<>();
15-
private boolean debugMode = false;
14+
private final List<TypeMapper> typeMappers = new ArrayList<>();
1615
public ORMConfig(){
1716
typeMappers.add(new DefaultMapper());
1817
}
@@ -51,12 +50,4 @@ public List<TypeMapper> getTypeMappers(){
5150
public boolean isIdPrimaryKey() {
5251
return idPrimaryKey;
5352
}
54-
55-
public void setDebugMode(boolean debugMode) {
56-
this.debugMode = debugMode;
57-
}
58-
59-
public boolean isDebugMode() {
60-
return debugMode;
61-
}
6253
}

src/main/java/org/javawebstack/orm/migration/AutoMigrator.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,7 @@ public static void migrate(Repo<?>... repos){
1919
Map<SQL, List<String>> tables = new HashMap<>();
2020
for(Repo<?> repo : repos){
2121
if(!tables.containsKey(repo.getConnection())){
22-
repo.getConnection().setDebugMode(repo.getInfo().getConfig().isDebugMode());
2322
tables.put(repo.getConnection(), getTables(repo.getConnection()));
24-
repo.getConnection().setDebugMode(false);
2523
}
2624
migrateTable(repo.getConnection(), repo.getInfo(), tables.get(repo.getConnection()).contains(repo.getInfo().getTableName()));
2725
}

src/main/java/org/javawebstack/orm/wrapper/BaseSQL.java

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,22 @@
11
package org.javawebstack.orm.wrapper;
22

3+
import org.javawebstack.orm.ORM;
4+
import org.javawebstack.orm.exception.ORMQueryException;
5+
36
import java.sql.*;
47
import java.util.HashMap;
58
import java.util.Locale;
69
import java.util.Map;
10+
import java.util.logging.Level;
711

812
public abstract class BaseSQL implements SQL {
913

1014
private final Map<ResultSet,Statement> statementMap = new HashMap<>();
11-
private boolean debugMode = false;
12-
13-
public void setDebugMode(boolean debugMode) {
14-
this.debugMode = debugMode;
15-
}
1615

1716
public abstract Connection getConnection();
1817

1918
public int write(String queryString,Object... parameters) throws SQLException {
20-
if(debugMode)
21-
System.out.println(queryString);
19+
ORM.LOGGER.log(Level.ALL, queryString);
2220
if(queryString.toLowerCase(Locale.ROOT).startsWith("insert")){
2321
PreparedStatement ps = setParams(getConnection().prepareStatement(queryString, Statement.RETURN_GENERATED_KEYS), parameters);
2422
ps.executeUpdate();
@@ -39,8 +37,7 @@ public int write(String queryString,Object... parameters) throws SQLException {
3937
}
4038

4139
public ResultSet read(String queryString, Object... parameters) throws SQLException {
42-
if(debugMode)
43-
System.out.println(queryString);
40+
ORM.LOGGER.log(Level.ALL, queryString);
4441
PreparedStatement ps = setParams(getConnection().prepareStatement(queryString), parameters);
4542
ResultSet rs = ps.executeQuery();
4643
statementMap.put(rs,ps);
@@ -77,7 +74,7 @@ else if(type.equals(Date.class))
7774
else if(type.equals(Time.class))
7875
st.setTime(i,(Time)object);
7976
else
80-
System.out.println("[SQL] Could not set type: "+object.getClass().getName());
77+
throw new ORMQueryException("Can't set parameter of type: "+object.getClass().getName());
8178
i++;
8279
}
8380
return st;
@@ -95,7 +92,7 @@ public void close(ResultSet rs){
9592
try {
9693
rs.close();
9794
} catch (SQLException e) {
98-
e.printStackTrace();
95+
throw new ORMQueryException(e);
9996
}
10097
}
10198

src/main/java/org/javawebstack/orm/wrapper/SQL.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,5 @@ public interface SQL {
1010
ResultSet read(String queryString, Object... parameters) throws SQLException;
1111
int write(String queryString, Object... parameters) throws SQLException;
1212
void close(ResultSet resultSet);
13-
void setDebugMode(boolean debugMode);
1413

1514
}

0 commit comments

Comments
 (0)