Skip to content

Commit d464bc9

Browse files
Change query building tests appropriately
1 parent 2c5365c commit d464bc9

File tree

1 file changed

+17
-16
lines changed

1 file changed

+17
-16
lines changed

src/test/java/org/javawebstack/orm/test/querybuilding/OrderByClauseTest.java

Lines changed: 17 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -21,50 +21,50 @@ public class OrderByClauseTest {
2121
@Test
2222
void testOneExistingColumnDefaultOrderBy() {
2323
Query<Datatype> query = setUpModel(Datatype.class).query()
24-
.order("wrapper_integer");
24+
.order("wrapperInteger");
2525
new QueryVerification(query).assertSectionEquals("ORDER BY", "`wrapper_integer`");
2626
}
2727

2828
@Test
2929
void testOneNonExistingColumnDefaultOrderBy() {
3030
Query<Datatype> query = setUpModel(Datatype.class).query()
31-
.order("does_not_exist");
31+
.order("doesNotExist");
3232
new QueryVerification(query).assertSectionEquals("ORDER BY", "`does_not_exist`");
3333
}
3434

3535
@Test
3636
void testOneExistingColumnASCOrderBy() {
3737
Query<Datatype> query = setUpModel(Datatype.class).query()
38-
.order("wrapper_integer", false);
38+
.order("wrapperInteger", false);
3939
new QueryVerification(query).assertSectionEquals("ORDER BY", "`wrapper_integer`");
4040
}
4141

4242
@Test
4343
void testOneNonExistingColumnASCOrderBy() {
4444
Query<Datatype> query = setUpModel(Datatype.class).query()
45-
.order("does_not_exist", false);
45+
.order("doesNotExist", false);
4646
new QueryVerification(query).assertSectionEquals("ORDER BY", "`does_not_exist`");
4747
}
4848

4949
@Test
5050
void testOneExistingColumnDESCOrderBy() {
5151
Query<Datatype> query = setUpModel(Datatype.class).query()
52-
.order("wrapper_integer", true);
52+
.order("wrapperInteger", true);
5353
new QueryVerification(query).assertSectionEquals("ORDER BY", "`wrapper_integer` DESC");
5454
}
5555

5656
@Test
5757
void testOneNonExistingColumnDESCOrderBy() {
5858
Query<Datatype> query = setUpModel(Datatype.class).query()
59-
.order("does_not_exist", true);
59+
.order("doesNotExist", true);
6060
new QueryVerification(query).assertSectionEquals("ORDER BY", "`does_not_exist` DESC");
6161
}
6262

6363
@Test
6464
void testMultipleOrderByClausesOfASCOrder() {
6565
Query<Datatype> query = setUpModel(Datatype.class).query()
66-
.order("wrapper_integer")
67-
.order("primitive_integer");
66+
.order("wrapperInteger")
67+
.order("primitiveInteger");
6868

6969
new QueryVerification(query)
7070
.assertSectionContains("ORDER BY", "`wrapper_integer`")
@@ -74,8 +74,8 @@ void testMultipleOrderByClausesOfASCOrder() {
7474
@Test
7575
void testMultipleOrderByClausesOfDESCOrder() {
7676
Query<Datatype> query = setUpModel(Datatype.class).query()
77-
.order("wrapper_integer", true)
78-
.order("primitive_integer", true);
77+
.order("wrapperInteger", true)
78+
.order("primitiveInteger", true);
7979

8080
new QueryVerification(query)
8181
.assertSectionContains("ORDER BY", "`wrapper_integer` DESC")
@@ -85,8 +85,8 @@ void testMultipleOrderByClausesOfDESCOrder() {
8585
@Test
8686
void testMultipleOrderByClausesOfMixedOrder() {
8787
Query<Datatype> query = setUpModel(Datatype.class).query()
88-
.order("wrapper_integer", false)
89-
.order("primitive_integer", true);
88+
.order("wrapperInteger", false)
89+
.order("primitiveInteger", true);
9090

9191
new QueryVerification(query)
9292
.assertSectionContains("ORDER BY", "`wrapper_integer`")
@@ -96,8 +96,8 @@ void testMultipleOrderByClausesOfMixedOrder() {
9696
@Test
9797
void testMultipleOrderByClausesOfMixedOrderReversed() {
9898
Query<Datatype> query = setUpModel(Datatype.class).query()
99-
.order("primitive_integer", true)
100-
.order("wrapper_integer", false);
99+
.order("primitiveInteger", true)
100+
.order("wrapperInteger", false);
101101

102102
new QueryVerification(query)
103103
.assertSectionContains("ORDER BY", "`primitive_integer` DESC")
@@ -108,6 +108,7 @@ void testMultipleOrderByClausesOfMixedOrderReversed() {
108108
@Test
109109
// This test is important because putting the order by statements in different order is relevant (they set priorities)
110110
void testMultipleOrderByClausesOfRandomOrderForCorrectOrder() throws SectionIndexOutOfBoundException {
111+
// This test does not use camel cases as input
111112
Query<Datatype> query = setUpModel(Datatype.class).query();
112113
ArrayList<String> columnNames = new ArrayList<>(Datatype.columnNames);
113114

@@ -149,8 +150,8 @@ void testMultipleOrderByClausesOfRandomOrderForCorrectOrder() throws SectionInde
149150
@Test
150151
void testCannotCallOrderOnSameColumnTwice() {
151152
Query<Datatype> query = setUpModel(Datatype.class).query()
152-
.order("primitive_integer", true);
153+
.order("primitiveInteger", true);
153154

154-
assertThrows(ORMQueryException.class, () -> query.order("primitive_integer"));
155+
assertThrows(ORMQueryException.class, () -> query.order("primitiveInteger"));
155156
}
156157
}

0 commit comments

Comments
 (0)