Merge pull request #24 from JavaWebStack/tests

Added tests and fixed bug in equals method of AbstractArray

Author: JanHolger

pom.xml

@@ -52,6 +52,12 @@
             <version>4.7.1</version>
             <optional>true</optional>
         </dependency>
+        <dependency>
+            <groupId>org.junit.jupiter</groupId>
+            <artifactId>junit-jupiter</artifactId>
+            <version>5.8.1</version>
+            <scope>test</scope>
+        </dependency>
     </dependencies>
 
     <build>

src/main/java/org/javawebstack/abstractdata/AbstractArray.java

@@ -350,7 +350,7 @@ public boolean equals(Object obj, boolean strict) {
             return false;
         try {
             AbstractArray arr = ((AbstractElement) obj).array(strict);
-            if (arr.size() != arr.size())
+            if (size() != arr.size())
                 return false;
 
             for (int i = 0; i < size(); i++) {

src/test/java/org/javawebstack/abstractdata/AbstractArrayTest.java

@@ -0,0 +1,44 @@
+package org.javawebstack.abstractdata;
+
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.*;
+
+class AbstractArrayTest {
+
+    @Test
+    void testEqualsNormal() {
+        AbstractArray first = new AbstractArray();
+        first.add("Hello");
+        AbstractArray second = new AbstractArray();
+        second.add("World");
+
+        assertFalse(first.equals(second));
+        assertFalse(second.equals(first));
+
+        second.set(0, "Hello");
+
+        assertTrue(first.equals(second));
+        assertTrue(second.equals(first));
+    }
+
+    @Test
+    void testEqualsDifferentSizes() {
+        AbstractArray first = new AbstractArray();
+        first.add("Hello");
+        AbstractArray second = new AbstractArray();
+        second.add("Hello");
+        second.add("World");
+
+        assertFalse(first.equals(second));
+        assertFalse(second.equals(first));
+    }
+
+    @Test
+    void testEqualsSpecial() {
+        AbstractArray first = new AbstractArray();
+        first.add("Hello");
+        assertFalse(first.equals(""));
+        assertFalse(first.equals(null));
+    }
+}

src/test/java/org/javawebstack/abstractdata/AbstractObjectTest.java

@@ -0,0 +1,50 @@
+package org.javawebstack.abstractdata;
+
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.*;
+
+class AbstractObjectTest {
+
+    @Test
+    void testEqualsNormal() {
+        AbstractObject first = new AbstractObject()
+                .set("a", "b")
+                .set("b", "c");
+        AbstractObject second = new AbstractObject()
+                .set("a", "b")
+                .set("b", "c");
+
+        // normal case
+        assertTrue(first.equals(second));
+        assertTrue(second.equals(first));
+
+        second.set("a", "d");
+        assertFalse(first.equals(second));
+        assertFalse(second.equals(first));
+
+        // different sizes
+        first.set("d" ,"a");
+        assertFalse(first.equals(second));
+        assertFalse(second.equals(first));
+    }
+
+    @Test
+    void testDifferentKeys() {
+        AbstractObject first = new AbstractObject()
+                .set("a", "b");
+        AbstractObject second = new AbstractObject()
+                .set("b", "c");
+
+        assertFalse(first.equals(second));
+    }
+
+    @Test
+    void testEqualsSpecial() {
+        AbstractObject first = new AbstractObject()
+                .set("a", "b")
+                .set("b", "c");
+        assertFalse(first.equals(null));
+        assertFalse(first.equals(""));
+    }
+}