Change htmlentities() to htmlspecialchars()

olivervogel · olivervogel · commit 080de0e638bc · 2025-05-05T15:53:52.000+02:00
diff --git a/src/FontProcessor.php b/src/FontProcessor.php
@@ -56,7 +56,7 @@ public function textToVipsImage(
         ColorInterface $color = new Color(0, 0, 0),
     ): VipsImage {
         return VipsImage::text(
-            '<span ' . $this->pangoAttributes($font, $color) . '>' . htmlentities($text) . '</span>',
+            '<span ' . $this->pangoAttributes($font, $color) . '>' . htmlspecialchars($text) . '</span>',
             [
                 'fontfile' => $font->filename(),
                 'font' => TrueTypeFont::fromPath($font->filename())->familyName() . ' ' . $font->size(),

Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ public function textToVipsImage(`
`56`	`56`	`ColorInterface $color = new Color(0, 0, 0),`
`57`	`57`	`): VipsImage {`
`58`	`58`	`return VipsImage::text(`
`59`		`- '<span ' . $this->pangoAttributes($font, $color) . '>' . htmlentities($text) . '</span>',`
	`59`	`+ '<span ' . $this->pangoAttributes($font, $color) . '>' . htmlspecialchars($text) . '</span>',`
`60`	`60`	`[`
`61`	`61`	`'fontfile' => $font->filename(),`
`62`	`62`	`'font' => TrueTypeFont::fromPath($font->filename())->familyName() . ' ' . $font->size(),`