-
Notifications
You must be signed in to change notification settings - Fork 23
Description
What
Once queryDrepDelegations is integrated into API IntersectMBO/cardano-api#974 it needs to be integrated on CLI. This query returns the delegators delegated to each DRep, including AlwaysAbstain and NoConfidence, and alternatively can be filtered by specific DRep credential.
So the final command should go cardano-cli conway query drep-delegations,
and apart from the usual boiler plate like --mainnet or --testnet, it should:
- take options for specifying specific drep-credentials by
- key hash,
- script hash,
- cip129 id
- predefined options always abstain and always no confidence.
- offer the usual output options:
- output-json
- output-yaml
- out-file
Why
It's very useful information for stake holders and dreps when in the middle of a governance action.
Personas
- SPOs
- dApp Devs
- Exchanges
- Wallets
- 3rd party tools
- ADA holders
- DReps
Definition of Done (DoD)
- Acceptance Criteria + User Stories & DoD created and singed-off (by PO, dev & test owners)
- Builds successfully on CI
- Code & Test review (as per Acceptance Criteria)
- There is documentation and/or examples for the new functionality (usage/response)
- Log/record changes on Vnext (or similar depending on what we adopt)
- Ticket number(s) included in PR description
- All Acceptance Criteria met and covered by dev/unit/property/integration tests
- System/E2E automated tests + System Test Engineer Owner Sign-off
NOTE: Ideally, we should merge only fully implemented and tested features into the master branch.
So all the above steps are required for the PR to be merged.
In order to avoid the PRs becoming stale and requiring to be rebased on master, these can be merged
after a reasonable time (current agreement is 3 days) if the System Test Engineer Owner's sign-off
was not provided (last step in the DoD).
IMPORTANT: Any deviation from the plan should be discussed and agreed as a comment in the Feature file.
Sign-off
- Product Owner
- Dev Owner
- System Test Engineer Owner
Related PRs
- PR # here
Acceptance Criteria
Acceptance Criteria & User Stories define here (or in a separate file (linked here) for a big feature)
Example - IntersectMBO/cardano-node#4453