factor patching tests into separate file

Author: ndgrigorian

.flake8

@@ -12,6 +12,8 @@ extend-ignore =
     D102,
     # missing docstring in public function:
     D103,
+    # missing docstring in public package:
+    D104,
     # missing docstring in __init__:
     D107,
     # 1 blank line required between summary line and description:

.github/workflows/build-with-clang.yml

@@ -77,4 +77,4 @@ jobs:
           # mkl_umath cannot be installed in editable mode, we need
           # to change directory before importing it and running tests
           cd ..
-          python -m pytest -sv --pyargs mkl_umath/mkl_umath/tests
+          python -m pytest -sv --pyargs mkl_umath

.github/workflows/build_pip.yaml

@@ -58,4 +58,4 @@ jobs:
           # mkl_umath cannot be installed in editable mode, we need
           # to change directory before importing it and running tests
           cd ..
-          python -m pytest -v mkl_umath/mkl_umath/tests
+          python -m pytest -v --pyargs mkl_umath

mkl_umath/tests/__init__.py

@@ -26,7 +26,6 @@
 import numpy as np
 import pytest
 
-import mkl_umath
 import mkl_umath._ufuncs as mu  # pylint: disable=no-name-in-module
 
 np.random.seed(42)
@@ -190,14 +189,3 @@ def test_reduce_complex(func, dtype):
     assert np.allclose(
         mkl_res, np_res
     ), f"Results for '{func}[reduce]' do not match"
-
-
-def test_patch():
-    mkl_umath.restore_numpy_umath()
-    assert not mkl_umath.is_patched()
-
-    mkl_umath.patch_numpy_umath()  # Enable mkl_umath in Numpy
-    assert mkl_umath.is_patched()
-
-    mkl_umath.restore_numpy_umath()  # Disable mkl_umath in Numpy
-    assert not mkl_umath.is_patched()

mkl_umath/tests/test_basic.py

@@ -0,0 +1,99 @@
+# Copyright (c) 2019, Intel Corporation
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions are met:
+#
+#     * Redistributions of source code must retain the above copyright notice,
+#       this list of conditions and the following disclaimer.
+#     * Redistributions in binary form must reproduce the above copyright
+#       notice, this list of conditions and the following disclaimer in the
+#       documentation and/or other materials provided with the distribution.
+#     * Neither the name of Intel Corporation nor the names of its contributors
+#       may be used to endorse or promote products derived from this software
+#       without specific prior written permission.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+# DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE
+# FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+# SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+# CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
+# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+import contextlib
+import sys
+from dataclasses import dataclass
+from io import StringIO
+
+import mkl_umath
+
+
+@dataclass
+class CapturedOutput:
+    stdout: str
+
+
+@contextlib.contextmanager
+def capture_output():
+    old_stdout = sys.stdout
+    capturer = StringIO()
+    sys.stdout = capturer
+    output = CapturedOutput(stdout="")
+    yield output
+    sys.stdout = old_stdout
+    output.stdout = capturer.getvalue()
+
+
+def test_patch_basic():
+    mkl_umath.restore_numpy_umath()
+    assert not mkl_umath.is_patched()
+
+    mkl_umath.patch_numpy_umath()  # Enable mkl_umath in Numpy
+    assert mkl_umath.is_patched()
+
+    mkl_umath.restore_numpy_umath()  # Disable mkl_umath in Numpy
+    assert not mkl_umath.is_patched()
+
+
+def test_patch_redundant_patching():
+    assert not mkl_umath.is_patched()
+
+    mkl_umath.patch_numpy_umath()
+    mkl_umath.patch_numpy_umath()
+
+    assert mkl_umath.is_patched()
+
+    mkl_umath.restore_numpy_umath()
+    assert mkl_umath.is_patched()
+
+    mkl_umath.restore_numpy_umath()
+    assert not mkl_umath.is_patched()
+
+
+def test_patch_reentrant():
+    assert not mkl_umath.is_patched()
+
+    with mkl_umath.mkl_umath():
+        assert mkl_umath.is_patched()
+
+        with mkl_umath.mkl_umath():
+            assert mkl_umath.is_patched()
+
+        assert mkl_umath.is_patched()
+
+    assert not mkl_umath.is_patched()
+
+
+def test_patch_verbose():
+    assert not mkl_umath.is_patched()
+
+    with capture_output() as output:
+        mkl_umath.patch_numpy_umath(verbose=True)
+    assert output.stdout
+    assert mkl_umath.is_patched()
+
+    mkl_umath.restore_numpy_umath()
+    assert not mkl_umath.is_patched()