From 4fb4986131e7d49b899e29ef25a793df72e3108b Mon Sep 17 00:00:00 2001 From: Anton Volkov Date: Wed, 26 Feb 2025 13:44:54 +0100 Subject: [PATCH 1/2] Add changelog and documentation to PR chore list --- .github/pull_request_template.md | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index b5edc3985308..846da21efc58 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,6 +1,8 @@ - [ ] Have you provided a meaningful PR description? -- [ ] Have you added a test, reproducer or referred to issue with a reproducer? +- [ ] Have you added a test, reproducer or referred to an issue with a reproducer? - [ ] Have you tested your changes locally for CPU and GPU devices? - [ ] Have you made sure that new changes do not introduce compiler warnings? - [ ] Have you checked performance impact of proposed changes? -- [ ] If this PR is a work in progress, are you filing the PR as a draft? +- [ ] Have you added documentation for your changes, if necessary? +- [ ] Have you added your changes to the changelog? +- [ ] If this PR is a work in progress, are you opening the PR as a draft? From 485be9a48aba6a61b1064839f90b5181e27582a1 Mon Sep 17 00:00:00 2001 From: Anton <100830759+antonwolfy@users.noreply.github.com> Date: Wed, 26 Feb 2025 15:17:07 +0100 Subject: [PATCH 2/2] Update .github/pull_request_template.md Co-authored-by: Vahid Tavanashad <120411540+vtavana@users.noreply.github.com> --- .github/pull_request_template.md | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 846da21efc58..3a916f3ad7f2 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -5,4 +5,3 @@ - [ ] Have you checked performance impact of proposed changes? - [ ] Have you added documentation for your changes, if necessary? - [ ] Have you added your changes to the changelog? -- [ ] If this PR is a work in progress, are you opening the PR as a draft?