From 4452d705fccc7938341732947df90fe04b646ea4 Mon Sep 17 00:00:00 2001 From: Laura Sandoval Date: Tue, 5 May 2026 15:37:18 -0600 Subject: [PATCH] added pointing id --- imap_processing/glows/l2/glows_l2_data.py | 5 +++-- imap_processing/tests/glows/test_glows_l2.py | 3 +++ imap_processing/tests/glows/test_glows_l2_data.py | 1 + 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/imap_processing/glows/l2/glows_l2_data.py b/imap_processing/glows/l2/glows_l2_data.py index e90e220483..cdbac16c0f 100644 --- a/imap_processing/glows/l2/glows_l2_data.py +++ b/imap_processing/glows/l2/glows_l2_data.py @@ -325,7 +325,7 @@ class HistogramL2: number_of_good_l1b_inputs: int total_l1b_inputs: int - identifier: int # TODO: Should be the official pointing number + identifier: int start_time: np.double end_time: np.double daily_lightcurve: DailyLightcurve @@ -391,7 +391,8 @@ def __init__( self.total_l1b_inputs = len(l1b_dataset["epoch"]) self.number_of_good_l1b_inputs = len(good_data["epoch"]) - self.identifier = -1 # TODO: retrieve from spin table + repointing = l1b_dataset.attrs.get("Repointing") + self.identifier = int(repointing.replace("repoint", "")) # TODO fill this in self.bad_time_flag_occurrences = np.zeros((1, FLAG_LENGTH)) diff --git a/imap_processing/tests/glows/test_glows_l2.py b/imap_processing/tests/glows/test_glows_l2.py index 0982f6fc3c..79713ab257 100644 --- a/imap_processing/tests/glows/test_glows_l2.py +++ b/imap_processing/tests/glows/test_glows_l2.py @@ -67,11 +67,13 @@ def test_glows_l2( mock_pipeline_settings, mock_conversion_table_dict, ) + l1b_hist_dataset.attrs["Repointing"] = "repoint00047" # Test case 1: L1B dataset has good times l2 = glows_l2(l1b_hist_dataset, mock_pipeline_settings, mock_calibration_dataset)[0] assert l2.attrs["Logical_source"] == "imap_glows_l2_hist" assert np.allclose(l2["filter_temperature_average"].values, [57.6], rtol=0.1) + assert l2["identifier"].values[0] == 47 assert "flight_software_version" in l2.attrs assert "pkts_file_name" in l2.attrs assert "flight_software_version" not in l2.data_vars @@ -130,6 +132,7 @@ def test_generate_l2( mock_pipeline_settings, mock_conversion_table_dict, ) + l1b_hist_dataset.attrs["Repointing"] = "repoint00047" day = et_to_datetime64(ttj2000ns_to_et(l1b_hist_dataset["epoch"].data[0])) pipeline_settings = PipelineSettings( mock_pipeline_settings.sel(epoch=day, method="nearest") diff --git a/imap_processing/tests/glows/test_glows_l2_data.py b/imap_processing/tests/glows/test_glows_l2_data.py index 7937b46e93..3c805918fd 100644 --- a/imap_processing/tests/glows/test_glows_l2_data.py +++ b/imap_processing/tests/glows/test_glows_l2_data.py @@ -483,6 +483,7 @@ def l1b_dataset_full(): "imap_time_offset": (["epoch"], [60.0, 60.0]), }, coords={"epoch": xr.DataArray(epoch, dims=["epoch"])}, + attrs={"Repointing": "repoint00047"}, )