Skip to content

Commit 48230a6

Browse files
committed
Address the comments
1 parent 223cba2 commit 48230a6

File tree

4 files changed

+6
-8
lines changed

4 files changed

+6
-8
lines changed

src/main/java/com/uid2/client/Uid2ClientHelper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
import java.io.IOException;
66

77
public class Uid2ClientHelper {
8-
public Uid2ClientHelper(String baseUrl, String clientApiKey) {
8+
Uid2ClientHelper(String baseUrl, String clientApiKey) {
99
this.baseUrl = baseUrl;
1010
this.headers = getHeaders(clientApiKey);
1111
}

src/test/java/com/uid2/client/BidstreamClientTests.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -276,7 +276,7 @@ private void decryptAndAssertSuccess(String token, TokenVersionForTesting tokenV
276276
assertSuccess(response, tokenVersion);
277277
}
278278

279-
public static void assertSuccess(DecryptionResponse response, TokenVersionForTesting tokenVersion) {
279+
static void assertSuccess(DecryptionResponse response, TokenVersionForTesting tokenVersion) {
280280
assertTrue(response.isSuccess());
281281
assertEquals(EXAMPLE_UID, response.getUid());
282282
assertEquals(tokenVersion.ordinal() + 2, response.getAdvertisingTokenVersion());
@@ -286,7 +286,7 @@ public static void assertSuccess(DecryptionResponse response, TokenVersionForTes
286286
}
287287
}
288288

289-
public static void assertFails(DecryptionResponse response, TokenVersionForTesting tokenVersion) {
289+
static void assertFails(DecryptionResponse response, TokenVersionForTesting tokenVersion) {
290290
assertFalse(response.isSuccess());
291291
assertEquals(DecryptionStatus.INVALID_TOKEN_LIFETIME, response.getStatus());
292292
assertEquals(tokenVersion.ordinal() + 2, response.getAdvertisingTokenVersion());

src/test/java/com/uid2/client/EncryptionTestsV4.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ public void crossPlatformConsistencyCheck_Decrypt() throws Exception {
9292
assertEquals(EXAMPLE_UID, res.getUid());
9393
}
9494

95-
public static void validateAdvertisingToken(String advertisingTokenString, IdentityScope identityScope, IdentityType identityType, TokenVersionForTesting tokenVersion) {
95+
static void validateAdvertisingToken(String advertisingTokenString, IdentityScope identityScope, IdentityType identityType, TokenVersionForTesting tokenVersion) {
9696
if (tokenVersion == TokenVersionForTesting.V2) {
9797
assertEquals("Ag", advertisingTokenString.substring(0, 2));
9898
return;

src/test/java/com/uid2/client/SharingClientTests.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -75,11 +75,11 @@ private static String keySharingResponse(IdentityScope identityScope, Key... key
7575
return keySharingResponse(identityScope, null, null, null, keys);
7676
}
7777

78-
public static String keySetToJsonForSharing(Key... keys) throws IOException {
78+
static String keySetToJsonForSharing(Key... keys) throws IOException {
7979
return keySharingResponse(IdentityScope.UID2, SITE_ID, 99999, null, keys);
8080
}
8181

82-
public static String keySetToJsonForSharing(IdentityScope identityScope, Key... keys) throws IOException {
82+
static String keySetToJsonForSharing(IdentityScope identityScope, Key... keys) throws IOException {
8383
return keySharingResponse(identityScope, SITE_ID, 99999, null, keys);
8484
}
8585

@@ -105,8 +105,6 @@ private void decryptAndAssertSuccess(String advertisingToken, TokenVersionForTes
105105
"UID2, V4",
106106
"EUID, V4"
107107
})
108-
109-
110108
public void smokeTest(IdentityScope identityScope, TokenVersionForTesting tokenVersion) throws Exception {
111109
String advertisingToken = AdvertisingTokenBuilder.builder().withScope(identityScope).withVersion(tokenVersion).build();
112110

0 commit comments

Comments
 (0)