Skip to content

Commit f3fda69

Browse files
Jonathan DixonAndroid (Google) Code Review
authored andcommitted
Merge "Minor code tidying up in WebStorage & GeolocationPermission"
2 parents c97ed10 + 36196b6 commit f3fda69

File tree

2 files changed

+3
-14
lines changed

2 files changed

+3
-14
lines changed

core/java/android/webkit/GeolocationPermissions.java

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,14 +18,12 @@
1818

1919
import android.os.Handler;
2020
import android.os.Message;
21-
import android.util.Log;
21+
2222
import java.util.HashMap;
23-
import java.util.HashSet;
2423
import java.util.Map;
2524
import java.util.Set;
2625
import java.util.Vector;
2726

28-
2927
/**
3028
* This class is used to manage permissions for the WebView's Geolocation
3129
* JavaScript API.
@@ -47,7 +45,7 @@
4745
* Geolocation permissions at any time.
4846
*/
4947
// This class is the Java counterpart of the WebKit C++ GeolocationPermissions
50-
// class. It simply marshalls calls from the UI thread to the WebKit thread.
48+
// class. It simply marshals calls from the UI thread to the WebKit thread.
5149
//
5250
// Within WebKit, Geolocation permissions may be applied either temporarily
5351
// (for the duration of the page) or permanently. This class deals only with
@@ -70,9 +68,6 @@ public interface Callback {
7068
public void invoke(String origin, boolean allow, boolean retain);
7169
};
7270

73-
// Log tag
74-
private static final String TAG = "geolocationPermissions";
75-
7671
// Global instance
7772
private static GeolocationPermissions sInstance;
7873

core/java/android/webkit/WebStorage.java

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,10 @@
1818

1919
import android.os.Handler;
2020
import android.os.Message;
21-
import android.util.Log;
2221

2322
import java.util.Collection;
24-
import java.util.Map;
2523
import java.util.HashMap;
26-
import java.util.HashSet;
27-
import java.util.Iterator;
24+
import java.util.Map;
2825
import java.util.Set;
2926

3027
/**
@@ -44,9 +41,6 @@ public interface QuotaUpdater {
4441
public void updateQuota(long newQuota);
4542
};
4643

47-
// Log tag
48-
private static final String TAG = "webstorage";
49-
5044
// Global instance of a WebStorage
5145
private static WebStorage sWebStorage;
5246

0 commit comments

Comments
 (0)