Remove the double-swipe to access quick settings on phones.

dsandler · dsandler · commit efb0faf1c043 · 2012-10-11T09:56:42.000-07:00
On the plus side, the settings button is back!

Now that we have two buttons on the right-hand side it's
more important than ever that the notification panel header
not allow errant taps to go all the way back to the
notification panel, where they will drag/close it.

Bug: 7319756 // remove double-swipe
Bug: 7217201 // finally make the notification header black
Change-Id: I8b2d6c7a7cfaaed2bfbcd61fb45db9f234cb002d
diff --git a/packages/SystemUI/res/drawable-hdpi/notification_header_bg.9.png b/packages/SystemUI/res/drawable-hdpi/notification_header_bg.9.png
diff --git a/packages/SystemUI/res/drawable-mdpi/notification_header_bg.9.png b/packages/SystemUI/res/drawable-mdpi/notification_header_bg.9.png
diff --git a/packages/SystemUI/res/drawable-xhdpi/notification_header_bg.9.png b/packages/SystemUI/res/drawable-xhdpi/notification_header_bg.9.png
diff --git a/packages/SystemUI/res/layout/status_bar_expanded_header.xml b/packages/SystemUI/res/layout/status_bar_expanded_header.xml
@@ -18,6 +18,7 @@
 <LinearLayout
     xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:systemui="http://schemas.android.com/apk/res/com.android.systemui"
+    android:id="@+id/header"
     android:layout_width="match_parent"
     android:layout_height="wrap_content"
     android:background="@drawable/notification_header_bg"
@@ -61,9 +62,18 @@
         android:padding="2dp"
         />
     
+    <ImageView android:id="@+id/settings_button"
+        android:layout_width="50dp"
+        android:layout_height="50dp"
+        android:scaleType="center"
+        android:src="@drawable/ic_notify_quicksettings"
+        android:contentDescription="@string/accessibility_settings_button"
+        />
+
     <ImageView android:id="@+id/clear_all_button"
-        android:layout_width="48dp"
-        android:layout_height="48dp"
+        android:layout_width="50dp"
+        android:layout_height="50dp"
+        android:layout_marginLeft="18dp"
         android:scaleType="center"
         android:src="@drawable/ic_notify_clear"
         android:contentDescription="@string/accessibility_clear_all"
diff --git a/packages/SystemUI/res/values/colors.xml b/packages/SystemUI/res/values/colors.xml
@@ -28,6 +28,7 @@
     <drawable name="recents_callout_line">#99ffffff</drawable>
     <drawable name="notification_item_background_legacy_color">#ffaaaaaa</drawable>
     <drawable name="intruder_bg_pressed">#ff33B5E5</drawable>
+    <drawable name="notification_header_bg">#FF000000</drawable>
 
     <!-- ==================== system bar only ==================== -->
     <drawable name="system_bar_background">#ff000000</drawable>
diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/phone/PanelBar.java b/packages/SystemUI/src/com/android/systemui/statusbar/phone/PanelBar.java
@@ -68,9 +68,9 @@ public float getBarHeight() {
         return getMeasuredHeight();
     }
 
-    public PanelView selectPanelForTouchX(float x) {
+    public PanelView selectPanelForTouch(MotionEvent touch) {
         final int N = mPanels.size();
-        return mPanels.get((int)(N * x / getMeasuredWidth()));
+        return mPanels.get((int)(N * touch.getX() / getMeasuredWidth()));
     }
 
     public boolean panelsEnabled() {
@@ -84,15 +84,26 @@ public boolean onTouchEvent(MotionEvent event) {
 
         // figure out which panel needs to be talked to here
         if (event.getAction() == MotionEvent.ACTION_DOWN) {
-            final PanelView panel = selectPanelForTouchX(event.getX());
+            final PanelView panel = selectPanelForTouch(event);
+            if (panel == null) {
+                // panel is not there, so we'll eat the gesture
+                if (DEBUG) LOG("PanelBar.onTouch: no panel for x=%d, bailing", event.getX());
+                mTouchingPanel = null;
+                return true;
+            }
             boolean enabled = panel.isEnabled();
             if (DEBUG) LOG("PanelBar.onTouch: state=%d ACTION_DOWN: panel %s %s", mState, panel,
                     (enabled ? "" : " (disabled)"));
-            if (!enabled)
-                return false;
+            if (!enabled) {
+                // panel is disabled, so we'll eat the gesture
+                mTouchingPanel = null;
+                return true;
+            }
             startOpeningPanel(panel);
         }
-        final boolean result = mTouchingPanel.getHandle().dispatchTouchEvent(event);
+        final boolean result = mTouchingPanel != null
+                ? mTouchingPanel.getHandle().dispatchTouchEvent(event)
+                : true;
         return result;
     }
 
diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/phone/PanelView.java b/packages/SystemUI/src/com/android/systemui/statusbar/phone/PanelView.java
@@ -23,7 +23,7 @@ public final void LOG(String fmt, Object... args) {
     }
 
     public static final boolean BRAKES = false;
-    private static final boolean STRETCH_PAST_CONTENTS = true;
+    private boolean mRubberbandingEnabled = true;
 
     private float mSelfExpandVelocityPx; // classic value: 2000px/s
     private float mSelfCollapseVelocityPx; // classic value: 2000px/s (will be negated to collapse "up")
@@ -86,6 +86,10 @@ public void run() {
     protected float mInitialTouchY;
     protected float mFinalTouchY;
 
+    public void setRubberbandingEnabled(boolean enable) {
+        mRubberbandingEnabled = enable;
+    }
+
     private void runPeekAnimation() {
         if (DEBUG) LOG("peek to height=%.1f", mPeekHeight);
         if (mTimeAnimator.isStarted()) {
@@ -109,7 +113,7 @@ private void animationTick(long dtms) {
 
             mTimeAnimator.start();
 
-            mRubberbanding = STRETCH_PAST_CONTENTS // is it enabled at all?
+            mRubberbanding = mRubberbandingEnabled // is it enabled at all?
                     && mExpandedHeight > getFullHeight() // are we past the end?
                     && mVel >= -mFlingGestureMinDistPx; // was this not possibly a "close" gesture?
             if (mRubberbanding) {
@@ -413,7 +417,7 @@ public void setExpandedHeightInternal(float h) {
         }
 
         if (h < 0) h = 0;
-        if (!(STRETCH_PAST_CONTENTS && (mTracking || mRubberbanding)) && h > fh) h = fh;
+        if (!(mRubberbandingEnabled && (mTracking || mRubberbanding)) && h > fh) h = fh;
         mExpandedHeight = h;
 
         if (DEBUG) LOG("setExpansion: height=%.1f fh=%.1f tracking=%s rubber=%s", h, fh, mTracking?"T":"f", mRubberbanding?"T":"f");
diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/phone/PhoneStatusBar.java b/packages/SystemUI/src/com/android/systemui/statusbar/phone/PhoneStatusBar.java
@@ -344,6 +344,7 @@ public boolean onTouch(View v, MotionEvent event) {
 
         mStatusBarView = (PhoneStatusBarView) mStatusBarWindow.findViewById(R.id.status_bar);
         mStatusBarView.setBar(this);
+        
 
         PanelHolder holder = (PanelHolder) mStatusBarWindow.findViewById(R.id.panel_holder);
         mStatusBarView.setPanelHolder(holder);
@@ -356,6 +357,15 @@ public boolean onTouch(View v, MotionEvent event) {
                   View.STATUS_BAR_DISABLE_NOTIFICATION_ICONS |
                   View.STATUS_BAR_DISABLE_CLOCK);
 
+        // make the header non-responsive to clicks
+        mNotificationPanel.findViewById(R.id.header).setOnTouchListener(
+                new View.OnTouchListener() {
+                    @Override
+                    public boolean onTouch(View v, MotionEvent event) {
+                        return true; // e eats everything
+                    }
+                });
+
         if (!ActivityManager.isHighEndGfx()) {
             mStatusBarWindow.setBackground(null);
             mNotificationPanel.setBackground(new FastColorDrawable(context.getResources().getColor(
@@ -410,7 +420,12 @@ public boolean onTouch(View v, MotionEvent event) {
         mDateView = (DateView)mStatusBarWindow.findViewById(R.id.date);
         mSettingsButton = mStatusBarWindow.findViewById(R.id.settings_button);
         if (mSettingsButton != null) {
-            mSettingsButton.setOnClickListener(mSettingsButtonListener);
+            if (mStatusBarView.hasFullWidthNotifications()) {
+                mSettingsButton.setOnClickListener(mSettingsButtonListener);
+                mSettingsButton.setVisibility(View.VISIBLE);
+            } else {
+                mSettingsButton.setVisibility(View.GONE);
+            }
         }
         
         mScrollView = (ScrollView)mStatusBarWindow.findViewById(R.id.scroll);
@@ -1900,18 +1915,7 @@ public void run() {
 
     private View.OnClickListener mSettingsButtonListener = new View.OnClickListener() {
         public void onClick(View v) {
-            // We take this as a good indicator that Setup is running and we shouldn't
-            // allow you to go somewhere else
-            if (!isDeviceProvisioned()) return;
-            try {
-                // Dismiss the lock screen when Settings starts.
-                ActivityManagerNative.getDefault().dismissKeyguardOnNextActivity();
-            } catch (RemoteException e) {
-            }
-            v.getContext().startActivityAsUser(new Intent(Settings.ACTION_SETTINGS)
-                    .setFlags(Intent.FLAG_ACTIVITY_NEW_TASK),
-                    new UserHandle(UserHandle.USER_CURRENT));
-            animateCollapsePanels();
+            animateExpandSettingsPanel();
         }
     };
 
diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/phone/PhoneStatusBarView.java b/packages/SystemUI/src/com/android/systemui/statusbar/phone/PhoneStatusBarView.java
@@ -45,14 +45,7 @@ public class PhoneStatusBarView extends PanelBar {
 
     public PhoneStatusBarView(Context context, AttributeSet attrs) {
         super(context, attrs);
-    }
-
-    public void setBar(PhoneStatusBar bar) {
-        mBar = bar;
-    }
 
-    @Override
-    public void onAttachedToWindow() {
         Resources res = getContext().getResources();
         mScrimColor = res.getColor(R.color.notification_panel_scrim_color);
         mSettingsPanelDragzoneMin = res.getDimension(R.dimen.settings_panel_dragzone_min);
@@ -61,10 +54,24 @@ public void onAttachedToWindow() {
         } catch (NotFoundException ex) {
             mSettingsPanelDragzoneFrac = 0f;
         }
-
         mFullWidthNotifications = mSettingsPanelDragzoneFrac <= 0f;
     }
 
+    public void setBar(PhoneStatusBar bar) {
+        mBar = bar;
+    }
+
+    public boolean hasFullWidthNotifications() {
+        return mFullWidthNotifications;
+    }
+
+    @Override
+    public void onAttachedToWindow() {
+        for (PanelView pv : mPanels) {
+            pv.setRubberbandingEnabled(!mFullWidthNotifications);
+        }
+    }
+
     @Override
     public void addPanel(PanelView pv) {
         super.addPanel(pv);
@@ -73,6 +80,7 @@ public void addPanel(PanelView pv) {
         } else if (pv.getId() == R.id.settings_panel){
             mSettingsPanel = pv;
         }
+        pv.setRubberbandingEnabled(!mFullWidthNotifications);
     }
 
     @Override
@@ -96,13 +104,14 @@ public boolean onRequestSendAccessibilityEvent(View child, AccessibilityEvent ev
     }
 
     @Override
-    public PanelView selectPanelForTouchX(float x) {
+    public PanelView selectPanelForTouch(MotionEvent touch) {
+        final float x = touch.getX();
+
         if (mFullWidthNotifications) {
-            if (DEBUG) {
-                Slog.v(TAG, "notif frac=" + mNotificationPanel.getExpandedFraction());
-            }
-            return (mNotificationPanel.getExpandedFraction() > 0f)
-                ? mSettingsPanel : mNotificationPanel;
+            // No double swiping. If either panel is open, nothing else can be pulled down.
+            return (mSettingsPanel.getExpandedHeight() + mNotificationPanel.getExpandedHeight()> 0) 
+                    ? null 
+                    : mNotificationPanel;
         }
 
         // We split the status bar into thirds: the left 2/3 are for notifications, and the
