Skip to content

Commit eb70fe5

Browse files
gkastenAndroid (Google) Code Review
authored andcommitted
Merge "AudioFlinger const methods and parameters"
2 parents 9bb891f + 0fccd35 commit eb70fe5

File tree

2 files changed

+11
-10
lines changed

2 files changed

+11
-10
lines changed

services/audioflinger/AudioFlinger.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3285,7 +3285,7 @@ void AudioFlinger::DuplicatingThread::updateWaitTime()
32853285
}
32863286

32873287

3288-
bool AudioFlinger::DuplicatingThread::outputsReady(SortedVector< sp<OutputTrack> > &outputTracks)
3288+
bool AudioFlinger::DuplicatingThread::outputsReady(const SortedVector< sp<OutputTrack> > &outputTracks)
32893289
{
32903290
for (size_t i = 0; i < outputTracks.size(); i++) {
32913291
sp <ThreadBase> thread = outputTracks[i]->thread().promote();
@@ -5870,7 +5870,7 @@ uint32_t AudioFlinger::nextUniqueId()
58705870
return android_atomic_inc(&mNextUniqueId);
58715871
}
58725872

5873-
AudioFlinger::PlaybackThread *AudioFlinger::primaryPlaybackThread_l()
5873+
AudioFlinger::PlaybackThread *AudioFlinger::primaryPlaybackThread_l() const
58745874
{
58755875
for (size_t i = 0; i < mPlaybackThreads.size(); i++) {
58765876
PlaybackThread *thread = mPlaybackThreads.valueAt(i).get();
@@ -5882,7 +5882,7 @@ AudioFlinger::PlaybackThread *AudioFlinger::primaryPlaybackThread_l()
58825882
return NULL;
58835883
}
58845884

5885-
uint32_t AudioFlinger::primaryOutputDevice_l()
5885+
uint32_t AudioFlinger::primaryOutputDevice_l() const
58865886
{
58875887
PlaybackThread *thread = primaryPlaybackThread_l();
58885888

@@ -6377,7 +6377,7 @@ void AudioFlinger::ThreadBase::lockEffectChains_l(
63776377
}
63786378

63796379
void AudioFlinger::ThreadBase::unlockEffectChains(
6380-
Vector<sp <AudioFlinger::EffectChain> >& effectChains)
6380+
const Vector<sp <AudioFlinger::EffectChain> >& effectChains)
63816381
{
63826382
for (size_t i = 0; i < effectChains.size(); i++) {
63836383
effectChains[i]->unlock();

services/audioflinger/AudioFlinger.h

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -423,8 +423,8 @@ class AudioFlinger :
423423
void sendConfigEvent_l(int event, int param = 0);
424424
void processConfigEvents();
425425
audio_io_handle_t id() const { return mId;}
426-
bool standby() { return mStandby; }
427-
uint32_t device() { return mDevice; }
426+
bool standby() const { return mStandby; }
427+
uint32_t device() const { return mDevice; }
428428
virtual audio_stream_t* stream() = 0;
429429

430430
sp<EffectHandle> createEffect_l(
@@ -460,7 +460,7 @@ class AudioFlinger :
460460
// integrity of the chains during the process.
461461
void lockEffectChains_l(Vector<sp <EffectChain> >& effectChains);
462462
// unlock effect chains after process
463-
void unlockEffectChains(Vector<sp <EffectChain> >& effectChains);
463+
void unlockEffectChains(const Vector<sp<EffectChain> >& effectChains);
464464
// set audio mode to all effect chains
465465
void setMode(audio_mode_t mode);
466466
// get effect module with corresponding ID on specified audio session
@@ -969,7 +969,7 @@ class AudioFlinger :
969969
virtual uint32_t activeSleepTimeUs();
970970

971971
private:
972-
bool outputsReady(SortedVector< sp<OutputTrack> > &outputTracks);
972+
bool outputsReady(const SortedVector<sp<OutputTrack> > &outputTracks);
973973
void updateWaitTime();
974974

975975
SortedVector < sp<OutputTrack> > mOutputTracks;
@@ -994,8 +994,9 @@ class AudioFlinger :
994994
PlaybackThread *srcThread,
995995
PlaybackThread *dstThread,
996996
bool reRegister);
997-
PlaybackThread *primaryPlaybackThread_l();
998-
uint32_t primaryOutputDevice_l();
997+
// return thread associated with primary hardware device, or NULL
998+
PlaybackThread *primaryPlaybackThread_l() const;
999+
uint32_t primaryOutputDevice_l() const;
9991000

10001001
friend class AudioBuffer;
10011002

0 commit comments

Comments
 (0)