Skip to content

Commit e8e9870

Browse files
Fabrice Di MeglioAndroid (Google) Code Review
authored andcommitted
Merge "Fix bug #7158772 ProgressBar / SeekBar / RatingBar drawables should be reversed when in RTL mode" into jb-mr1-dev
2 parents e79275a + 7fb98b3 commit e8e9870

File tree

5 files changed

+12
-10
lines changed

5 files changed

+12
-10
lines changed

core/java/android/widget/ProgressBar.java

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -354,7 +354,7 @@ private Drawable tileify(Drawable drawable, boolean clip) {
354354
Shader.TileMode.REPEAT, Shader.TileMode.CLAMP);
355355
shapeDrawable.getPaint().setShader(bitmapShader);
356356

357-
return (clip) ? new ClipDrawable(shapeDrawable, Gravity.START,
357+
return (clip) ? new ClipDrawable(shapeDrawable, Gravity.LEFT,
358358
ClipDrawable.HORIZONTAL) : shapeDrawable;
359359
}
360360

@@ -1040,6 +1040,11 @@ private void updateDrawableBounds(int w, int h) {
10401040
}
10411041
}
10421042
}
1043+
if (isLayoutRtl()) {
1044+
int tempLeft = left;
1045+
left = w - right;
1046+
right = w - tempLeft;
1047+
}
10431048
mIndeterminateDrawable.setBounds(left, top, right, bottom);
10441049
}
10451050

@@ -1057,7 +1062,12 @@ protected synchronized void onDraw(Canvas canvas) {
10571062
// Translate canvas so a indeterminate circular progress bar with padding
10581063
// rotates properly in its animation
10591064
canvas.save();
1060-
canvas.translate(mPaddingLeft, mPaddingTop);
1065+
if(isLayoutRtl()) {
1066+
canvas.translate(getWidth() - mPaddingRight, mPaddingTop);
1067+
canvas.scale(-1.0f, 1.0f);
1068+
} else {
1069+
canvas.translate(mPaddingLeft, mPaddingTop);
1070+
}
10611071
long time = getDrawingTime();
10621072
if (mHasAnimation) {
10631073
mAnimation.getTransformation(time, mTransformation);

core/res/res/drawable/progress_horizontal_holo_dark.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,11 @@
2121

2222
<item android:id="@android:id/secondaryProgress">
2323
<scale android:scaleWidth="100%"
24-
android:scaleGravity="start"
2524
android:drawable="@android:drawable/progress_secondary_holo_dark" />
2625
</item>
2726

2827
<item android:id="@android:id/progress">
2928
<scale android:scaleWidth="100%"
30-
android:scaleGravity="start"
3129
android:drawable="@android:drawable/progress_primary_holo_dark" />
3230
</item>
3331

core/res/res/drawable/progress_horizontal_holo_light.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,11 @@
2121

2222
<item android:id="@android:id/secondaryProgress">
2323
<scale android:scaleWidth="100%"
24-
android:scaleGravity="start"
2524
android:drawable="@android:drawable/progress_secondary_holo_light" />
2625
</item>
2726

2827
<item android:id="@android:id/progress">
2928
<scale android:scaleWidth="100%"
30-
android:scaleGravity="start"
3129
android:drawable="@android:drawable/progress_primary_holo_light" />
3230
</item>
3331

core/res/res/drawable/scrubber_progress_horizontal_holo_dark.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,10 @@
1919
android:drawable="@android:drawable/scrubber_track_holo_dark" />
2020
<item android:id="@android:id/secondaryProgress">
2121
<scale android:scaleWidth="100%"
22-
android:scaleGravity="start"
2322
android:drawable="@android:drawable/scrubber_secondary_holo" />
2423
</item>
2524
<item android:id="@android:id/progress">
2625
<scale android:scaleWidth="100%"
27-
android:scaleGravity="start"
2826
android:drawable="@android:drawable/scrubber_primary_holo" />
2927
</item>
3028
</layer-list>

core/res/res/drawable/scrubber_progress_horizontal_holo_light.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,10 @@
1919
android:drawable="@android:drawable/scrubber_track_holo_light" />
2020
<item android:id="@android:id/secondaryProgress">
2121
<scale android:scaleWidth="100%"
22-
android:scaleGravity="start"
2322
android:drawable="@android:drawable/scrubber_secondary_holo" />
2423
</item>
2524
<item android:id="@android:id/progress">
2625
<scale android:scaleWidth="100%"
27-
android:scaleGravity="start"
2826
android:drawable="@android:drawable/scrubber_primary_holo" />
2927
</item>
3028
</layer-list>

0 commit comments

Comments
 (0)