Skip to content

Commit d30b897

Browse files
Christopher TateAndroid (Google) Code Review
authored andcommitted
Merge "Move full backup/restore onto dedicated threads"
2 parents 465d42e + a28e854 commit d30b897

File tree

1 file changed

+12
-4
lines changed

1 file changed

+12
-4
lines changed

services/java/com/android/server/BackupManagerService.java

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -497,10 +497,14 @@ public void handleMessage(Message msg) {
497497

498498
case MSG_RUN_FULL_BACKUP:
499499
{
500+
// TODO: refactor full backup to be a looper-based state machine
501+
// similar to normal backup/restore.
500502
FullBackupParams params = (FullBackupParams)msg.obj;
501-
(new PerformFullBackupTask(params.fd, params.observer, params.includeApks,
503+
PerformFullBackupTask task = new PerformFullBackupTask(params.fd,
504+
params.observer, params.includeApks,
502505
params.includeShared, params.curPassword, params.encryptPassword,
503-
params.allApps, params.packages, params.latch)).run();
506+
params.allApps, params.packages, params.latch);
507+
(new Thread(task)).start();
504508
break;
505509
}
506510

@@ -519,9 +523,13 @@ public void handleMessage(Message msg) {
519523

520524
case MSG_RUN_FULL_RESTORE:
521525
{
526+
// TODO: refactor full restore to be a looper-based state machine
527+
// similar to normal backup/restore.
522528
FullRestoreParams params = (FullRestoreParams)msg.obj;
523-
(new PerformFullRestoreTask(params.fd, params.curPassword, params.encryptPassword,
524-
params.observer, params.latch)).run();
529+
PerformFullRestoreTask task = new PerformFullRestoreTask(params.fd,
530+
params.curPassword, params.encryptPassword,
531+
params.observer, params.latch);
532+
(new Thread(task)).start();
525533
break;
526534
}
527535

0 commit comments

Comments
 (0)