Skip to content

Commit cf8d907

Browse files
author
Brian Colonna
committed
Fix 5849324: Changed FUL extents for pattern backup
The extents of FUL when using PIN unlock are such that there are 4 dps of space between FUL and the adjacent text above and below. The extents of FUL when using pattern backup were such that FUL was very far below the adjacent text above. Pattern backup is now consistent with PIN backup - 4 dps of space between FUL and the adjacent text above and below. Note that it is not possible for FUL to be the same exact size when using pattern backup vs. PIN backup because the rest of the layout is different. Making it a consistent distance from the surrounding text is the best we can do. To fix this, the FUL area simply had to cover an extra row in the grid layout (a space view), and the top and bottom margins had to be set to 4 dp. Since only the FUL view is affected, it does not impact the rest of the layout. This has been tested on both a Prime and Crespo to make sure it works across different size devices. All lock methods have been tested to make sure other methods were not affected. Change-Id: I518f1b616cf7bedc510979d422ebc72e07a5aff4
1 parent 1c35d11 commit cf8d907

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

core/res/res/layout/keyguard_screen_unlock_portrait.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -173,13 +173,13 @@
173173
<RelativeLayout
174174
android:id="@+id/faceLockAreaView"
175175
android:visibility="invisible"
176-
android:layout_row="4"
176+
android:layout_row="3"
177177
android:layout_column="0"
178-
android:layout_rowSpan="1"
178+
android:layout_rowSpan="2"
179179
android:layout_columnSpan="1"
180180
android:layout_gravity="fill"
181-
android:layout_marginTop="8dip"
182-
android:layout_marginBottom="8dip"
181+
android:layout_marginTop="4dip"
182+
android:layout_marginBottom="4dip"
183183
android:layout_width="0dip"
184184
android:layout_height="0dip"
185185
android:background="@drawable/intro_bg">

0 commit comments

Comments
 (0)