Skip to content

Commit cd9ea08

Browse files
author
Amith Yamasani
committed
Fix amnesia problem in MultiSelectListPreference.
Bug: 6478079 Pointer assignment instead of copy was resulting in mValues being cleared on next launch, since mValues became the same pointer as mNewValues. Change-Id: I91014948e4f48056474b3ab31aab6d35e0ad69ca
1 parent 6387c8a commit cd9ea08

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

core/java/android/preference/MultiSelectListPreference.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -125,8 +125,9 @@ public CharSequence[] getEntryValues() {
125125
* @param values The values to set for the key.
126126
*/
127127
public void setValues(Set<String> values) {
128-
mValues = values;
129-
128+
mValues.clear();
129+
mValues.addAll(values);
130+
130131
persistStringSet(values);
131132
}
132133

0 commit comments

Comments
 (0)