Merge "Don't reuse StringBuilder outside of lock when dumping ANR."

Jeff Brown · Android (Google) Code Review · commit cd2a3ea5c8aa · 2012-04-10T14:30:20.000-07:00
diff --git a/services/java/com/android/server/am/ActivityManagerService.java b/services/java/com/android/server/am/ActivityManagerService.java
@@ -3181,7 +3181,7 @@ final void appNotResponding(ProcessRecord app, ActivityRecord activity,
         }
 
         // Log the ANR to the main log.
-        StringBuilder info = mStringBuilder;
+        StringBuilder info = new StringBuilder();
         info.setLength(0);
         info.append("ANR in ").append(app.processName);
         if (activity != null && activity.shortComponentName != null) {

Original file line number	Diff line number	Diff line change
`@@ -3181,7 +3181,7 @@ final void appNotResponding(ProcessRecord app, ActivityRecord activity,`
`3181`	`3181`	`}`
`3182`	`3182`
`3183`	`3183`	`// Log the ANR to the main log.`
`3184`		`- StringBuilder info = mStringBuilder;`
	`3184`	`+ StringBuilder info = new StringBuilder();`
`3185`	`3185`	`info.setLength(0);`
`3186`	`3186`	`info.append("ANR in ").append(app.processName);`
`3187`	`3187`	`if (activity != null && activity.shortComponentName != null) {`