Skip to content

Commit c9e22e9

Browse files
author
Jean-Baptiste Queru
committed
Switch to SkSafeUnref for better portability
Change-Id: Ia146a4728b5eb92626462effe42521ca73454a7d
1 parent 87d8604 commit c9e22e9

File tree

10 files changed

+13
-13
lines changed

10 files changed

+13
-13
lines changed

core/jni/android/graphics/Bitmap.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -363,12 +363,12 @@ static jobject Bitmap_createFromParcel(JNIEnv* env, jobject, jobject parcel) {
363363
}
364364

365365
if (!GraphicsJNI::setJavaPixelRef(env, bitmap, ctable, true)) {
366-
ctable->safeUnref();
366+
SkSafeUnref(ctable);
367367
delete bitmap;
368368
return NULL;
369369
}
370370

371-
ctable->safeUnref();
371+
SkSafeUnref(ctable);
372372

373373
size_t size = bitmap->getSize();
374374
bitmap->lockPixels();

core/jni/android/graphics/Canvas.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -680,7 +680,7 @@ class SkCanvasGlue {
680680
}
681681
SkShader* shader = SkShader::CreateBitmapShader(*bitmap,
682682
SkShader::kClamp_TileMode, SkShader::kClamp_TileMode);
683-
tmpPaint.setShader(shader)->safeUnref();
683+
SkSafeUnref(tmpPaint.setShader(shader));
684684

685685
canvas->drawVertices(SkCanvas::kTriangles_VertexMode, ptCount, verts,
686686
texs, (const SkColor*)colorA.ptr(), NULL, indices,

core/jni/android/graphics/ColorFilter.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ class SkColorFilterGlue {
2929
public:
3030

3131
static void finalizer(JNIEnv* env, jobject clazz, SkColorFilter* obj) {
32-
obj->safeUnref();
32+
SkSafeUnref(obj);
3333
}
3434

3535
static SkColorFilter* CreatePorterDuffFilter(JNIEnv* env, jobject,

core/jni/android/graphics/DrawFilter.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ class SkDrawFilterGlue {
3434
public:
3535

3636
static void finalizer(JNIEnv* env, jobject clazz, SkDrawFilter* obj) {
37-
obj->safeUnref();
37+
SkSafeUnref(obj);
3838
}
3939

4040
static SkDrawFilter* CreatePaintFlagsDF(JNIEnv* env, jobject clazz,

core/jni/android/graphics/MaskFilter.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ static void ThrowIAE_IfNull(JNIEnv* env, void* ptr) {
1414
class SkMaskFilterGlue {
1515
public:
1616
static void destructor(JNIEnv* env, jobject, SkMaskFilter* filter) {
17-
filter->safeUnref();
17+
SkSafeUnref(filter);
1818
}
1919

2020
static SkMaskFilter* createBlur(JNIEnv* env, jobject, float radius, int blurStyle) {

core/jni/android/graphics/PathEffect.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ class SkPathEffectGlue {
1212
public:
1313

1414
static void destructor(JNIEnv* env, jobject, SkPathEffect* effect) {
15-
effect->safeUnref();
15+
SkSafeUnref(effect);
1616
}
1717

1818
static SkPathEffect* Compose_constructor(JNIEnv* env, jobject,

core/jni/android/graphics/Rasterizer.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ class SkRasterizerGlue {
3232
public:
3333

3434
static void finalizer(JNIEnv* env, jobject clazz, SkRasterizer* obj) {
35-
obj->safeUnref();
35+
SkSafeUnref(obj);
3636
}
3737

3838
};

core/jni/android/graphics/Shader.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ static int Color_HSVToColor(JNIEnv* env, jobject, int alpha, jfloatArray hsvArra
4343

4444
static void Shader_destructor(JNIEnv* env, jobject, SkShader* shader)
4545
{
46-
shader->safeUnref();
46+
SkSafeUnref(shader);
4747
}
4848

4949
static bool Shader_getLocalMatrix(JNIEnv* env, jobject, const SkShader* shader, SkMatrix* matrix)

core/jni/android/graphics/Xfermode.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ class SkXfermodeGlue {
2828

2929
static void finalizer(JNIEnv* env, jobject, SkXfermode* obj)
3030
{
31-
obj->safeUnref();
31+
SkSafeUnref(obj);
3232
}
3333

3434
static SkXfermode* avoid_create(JNIEnv* env, jobject, SkColor opColor,

core/jni/com_google_android_gles_jni_EGLImpl.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -290,7 +290,7 @@ static void jni_eglCreatePixmapSurface(JNIEnv *_env, jobject _this, jobject out_
290290
return;
291291
}
292292

293-
ref->safeRef();
293+
SkSafeRef(ref);
294294
ref->lockPixels();
295295

296296
egl_native_pixmap_t pixmap;
@@ -310,7 +310,7 @@ static void jni_eglCreatePixmapSurface(JNIEnv *_env, jobject _this, jobject out_
310310
_env->SetIntField(out_sur, gSurface_NativePixelRefFieldID, (int)ref);
311311
} else {
312312
ref->unlockPixels();
313-
ref->safeUnref();
313+
SkSafeUnref(ref);
314314
}
315315
}
316316

@@ -430,7 +430,7 @@ static jboolean jni_eglDestroySurface(JNIEnv *_env, jobject _this, jobject displ
430430
gSurface_NativePixelRefFieldID));
431431
if (ref) {
432432
ref->unlockPixels();
433-
ref->safeUnref();
433+
SkSafeUnref(ref);
434434
}
435435
}
436436
return eglDestroySurface(dpy, sur);

0 commit comments

Comments
 (0)