Skip to content

Commit c49c71a

Browse files
stephenhinesAndroid (Google) Code Review
authored andcommitted
Merge "Restore RSTest functionality (char bug is fixed)." into jb-mr1-dev
2 parents dd78d46 + 8d60b1e commit c49c71a

File tree

2 files changed

+1
-16
lines changed

2 files changed

+1
-16
lines changed

tests/RenderScriptTests/tests/src/com/android/rs/test/UT_math_agree.java

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -347,8 +347,6 @@ private void initializeValues(ScriptC_math_agree s) {
347347
long[] rand_sl2_1 = randvec_long(2);
348348
long[] rand_sl3_1 = randvec_long(3);
349349
long[] rand_sl4_1 = randvec_long(4);
350-
// FIXME: generate signed char vectors once bug 6865598 is fixed
351-
/*
352350
byte rand_sc1_0 = (byte)rand.nextInt(0x1 << 8);
353351
byte[] rand_sc2_0 = randvec_char(2);
354352
byte[] rand_sc3_0 = randvec_char(3);
@@ -357,7 +355,6 @@ private void initializeValues(ScriptC_math_agree s) {
357355
byte[] rand_sc2_1 = randvec_char(2);
358356
byte[] rand_sc3_1 = randvec_char(3);
359357
byte[] rand_sc4_1 = randvec_char(4);
360-
*/
361358
// TODO: generate unsigned long vectors
362359

363360
// Set random vectors in renderscript code
@@ -417,8 +414,6 @@ private void initializeValues(ScriptC_math_agree s) {
417414
s.set_rand_uc2_0(pack_s2(rand_uc2_0));
418415
s.set_rand_uc3_0(pack_s3(rand_uc3_0));
419416
s.set_rand_uc4_0(pack_s4(rand_uc4_0));
420-
// FIXME: set char input vectors once bug 6865598 is fixed
421-
/*
422417
s.set_rand_sc1_0(rand_sc1_0);
423418
s.set_rand_sc2_0(pack_b2(rand_sc2_0));
424419
s.set_rand_sc3_0(pack_b3(rand_sc3_0));
@@ -427,7 +422,6 @@ private void initializeValues(ScriptC_math_agree s) {
427422
s.set_rand_sc2_1(pack_b2(rand_sc2_1));
428423
s.set_rand_sc3_1(pack_b3(rand_sc3_1));
429424
s.set_rand_sc4_1(pack_b4(rand_sc4_1));
430-
*/
431425
// TODO: set unsigned long vectors
432426

433427
// Set results for min
@@ -459,13 +453,10 @@ private void initializeValues(ScriptC_math_agree s) {
459453
s.set_min_rand_sl2_sl2(pack_l2(min(rand_sl2_0, rand_sl2_1)));
460454
s.set_min_rand_sl3_sl3(pack_l3(min(rand_sl3_0, rand_sl3_1)));
461455
s.set_min_rand_sl4_sl4(pack_l4(min(rand_sl4_0, rand_sl4_1)));
462-
// FIXME: set char min reference vectors once bug 6865598 is fixed
463-
/*
464456
s.set_min_rand_sc1_sc1(min(rand_sc1_0, rand_sc1_1));
465457
s.set_min_rand_sc2_sc2(pack_b2(min(rand_sc2_0, rand_sc2_1)));
466458
s.set_min_rand_sc3_sc3(pack_b3(min(rand_sc3_0, rand_sc3_1)));
467459
s.set_min_rand_sc4_sc4(pack_b4(min(rand_sc4_0, rand_sc4_1)));
468-
*/
469460
// TODO: set results for unsigned long min
470461

471462
// Set results for max
@@ -497,13 +488,10 @@ private void initializeValues(ScriptC_math_agree s) {
497488
s.set_max_rand_sl2_sl2(pack_l2(max(rand_sl2_0, rand_sl2_1)));
498489
s.set_max_rand_sl3_sl3(pack_l3(max(rand_sl3_0, rand_sl3_1)));
499490
s.set_max_rand_sl4_sl4(pack_l4(max(rand_sl4_0, rand_sl4_1)));
500-
// FIXME: set signed char max reference vectors once bug 6865598 is fixed
501-
/*
502491
s.set_max_rand_sc1_sc1(max(rand_sc1_0, rand_sc1_1));
503492
s.set_max_rand_sc2_sc2(pack_b2(max(rand_sc2_0, rand_sc2_1)));
504493
s.set_max_rand_sc3_sc3(pack_b3(max(rand_sc3_0, rand_sc3_1)));
505494
s.set_max_rand_sc4_sc4(pack_b4(max(rand_sc4_0, rand_sc4_1)));
506-
*/
507495

508496
// TODO: set results for unsigned long max
509497

tests/RenderScriptTests/tests/src/com/android/rs/test/math_agree.rs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -338,16 +338,13 @@ TEST_UL4_UL4(func)
338338

339339
#define TEST_VEC_VEC_ALL(func) \
340340
TEST_FN_FN_ALL(func) \
341+
TEST_SC_SC_ALL(func) \
341342
TEST_UC_UC_ALL(func) \
342343
TEST_SS_SS_ALL(func) \
343344
TEST_US_US_ALL(func) \
344345
TEST_SI_SI_ALL(func) \
345346
TEST_UI_UI_ALL(func)
346347

347-
// FIXME: Add char tests back in once bug 6865598 is fixed
348-
#if 0
349-
TEST_SC_SC_ALL(func)
350-
#endif
351348
// TODO: add long types to ALL macro
352349
#if 0
353350
TEST_SL_SL_ALL(func) \

0 commit comments

Comments
 (0)