aapt: Remove terminal pointer incrementaion

nobhys · nobhys · commit c4293c14083d · 2012-03-30T19:23:04.000+09:00
When initialization, 'end' pointer refers terminal character in a string. But it is incremented in while loop. It occurs the access to non-secure memory. Issue detail http://code.google.com/p/android/issues/detail?id=24896 Change-Id: I751d1154d797738c87a66374a66933528c045be5
diff --git a/tools/aapt/ResourceTable.cpp b/tools/aapt/ResourceTable.cpp
@@ -2253,7 +2253,6 @@ bool ResourceTable::getAttributeFlags(
         bool failed = false;
         while (pos < end && !failed) {
             const char16_t* start = pos;
-            end++;
             while (pos < end && *pos != '|') {
                 pos++;
             }

Original file line number	Diff line number	Diff line change
`@@ -2253,7 +2253,6 @@ bool ResourceTable::getAttributeFlags(`
`2253`	`2253`	`bool failed = false;`
`2254`	`2254`	`while (pos < end && !failed) {`
`2255`	`2255`	`const char16_t* start = pos;`
`2256`		`- end++;`
`2257`	`2256`	`while (pos < end && *pos != '\|') {`
`2258`	`2257`	`pos++;`
`2259`	`2258`	`}`