Skip to content

Commit c318bbb

Browse files
Jean-Baptiste Queruandroid code review
authored andcommitted
Merge "Rename (IF_)LOG() to (IF_)ALOG()"
2 parents b4cee0f + ad3f514 commit c318bbb

File tree

9 files changed

+20
-20
lines changed

9 files changed

+20
-20
lines changed

core/jni/android/graphics/TextLayout.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ int TextLayout::shapeRtlText(const jchar* context, jsize start, jsize count, jsi
7878
}
7979
}
8080
count = end;
81-
// LOG(LOG_INFO, "CSRTL", "start %d count %d ccount %d\n", start, count, contextCount);
81+
// ALOG(LOG_INFO, "CSRTL", "start %d count %d ccount %d\n", start, count, contextCount);
8282
ubidi_writeReverse(buffer, count, shaped, count, UBIDI_DO_MIRRORING | UBIDI_OUTPUT_REVERSE
8383
| UBIDI_KEEP_BASE_COMBINING, &status);
8484
if (U_SUCCESS(status)) {
@@ -125,7 +125,7 @@ jint TextLayout::layoutLine(const jchar* text, jint len, jint flags, int& dir, j
125125

126126
int rc = ubidi_countRuns(bidi, &status);
127127
if (U_SUCCESS(status)) {
128-
// LOG(LOG_INFO, "LAYOUT", "para bidiReq=%d dir=%d rc=%d\n", bidiReq, dir, rc);
128+
// ALOG(LOG_INFO, "LAYOUT", "para bidiReq=%d dir=%d rc=%d\n", bidiReq, dir, rc);
129129

130130
int32_t slen = 0;
131131
for (int i = 0; i < rc; ++i) {
@@ -164,7 +164,7 @@ bool TextLayout::prepareText(SkPaint* paint, const jchar* text, jsize len, jint
164164
UErrorCode status = U_ZERO_ERROR;
165165
len = layoutLine(text, len, bidiFlags, dir, buffer, status); // might change len, dir
166166
if (!U_SUCCESS(status)) {
167-
LOG(LOG_WARN, "LAYOUT", "drawText error %d\n", status);
167+
ALOG(LOG_WARN, "LAYOUT", "drawText error %d\n", status);
168168
free(buffer);
169169
return false; // can't render
170170
}

core/jni/android_app_NativeActivity.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
#include "android_view_KeyEvent.h"
3737

3838
#define LOG_TRACE(...)
39-
//#define LOG_TRACE(...) LOG(LOG_DEBUG, LOG_TAG, __VA_ARGS__)
39+
//#define LOG_TRACE(...) ALOG(LOG_DEBUG, LOG_TAG, __VA_ARGS__)
4040

4141
namespace android
4242
{

core/jni/android_bluetooth_HeadsetBase.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -494,7 +494,7 @@ static void pretty_log_urc(const char *urc) {
494494
}
495495
}
496496
}
497-
IF_LOGV() LOG(LOG_VERBOSE, "Bluetooth AT sent", "%s", buf);
497+
IF_LOGV() ALOG(LOG_VERBOSE, "Bluetooth AT sent", "%s", buf);
498498

499499
free(buf);
500500
}

core/jni/android_nfc.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
extern "C" {
2929

3030
#if 0
31-
#define TRACE(...) LOG(LOG_DEBUG, "NdefMessage", __VA_ARGS__)
31+
#define TRACE(...) ALOG(LOG_DEBUG, "NdefMessage", __VA_ARGS__)
3232
#else
3333
#define TRACE(...)
3434
#endif

include/binder/CursorWindow.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@
3131

3232
#else
3333

34-
#define IF_LOG_WINDOW() IF_LOG(LOG_DEBUG, "CursorWindow")
35-
#define LOG_WINDOW(...) LOG(LOG_DEBUG, "CursorWindow", __VA_ARGS__)
34+
#define IF_LOG_WINDOW() IF_ALOG(LOG_DEBUG, "CursorWindow")
35+
#define LOG_WINDOW(...) ALOG(LOG_DEBUG, "CursorWindow", __VA_ARGS__)
3636

3737
#endif
3838

libs/binder/IPCThreadState.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -56,12 +56,12 @@
5656

5757
#else
5858

59-
#define IF_LOG_TRANSACTIONS() IF_LOG(LOG_VERBOSE, "transact")
60-
#define IF_LOG_COMMANDS() IF_LOG(LOG_VERBOSE, "ipc")
61-
#define LOG_REMOTEREFS(...) LOG(LOG_DEBUG, "remoterefs", __VA_ARGS__)
62-
#define IF_LOG_REMOTEREFS() IF_LOG(LOG_DEBUG, "remoterefs")
63-
#define LOG_THREADPOOL(...) LOG(LOG_DEBUG, "threadpool", __VA_ARGS__)
64-
#define LOG_ONEWAY(...) LOG(LOG_DEBUG, "ipc", __VA_ARGS__)
59+
#define IF_LOG_TRANSACTIONS() IF_ALOG(LOG_VERBOSE, "transact")
60+
#define IF_LOG_COMMANDS() IF_ALOG(LOG_VERBOSE, "ipc")
61+
#define LOG_REMOTEREFS(...) ALOG(LOG_DEBUG, "remoterefs", __VA_ARGS__)
62+
#define IF_LOG_REMOTEREFS() IF_ALOG(LOG_DEBUG, "remoterefs")
63+
#define LOG_THREADPOOL(...) ALOG(LOG_DEBUG, "threadpool", __VA_ARGS__)
64+
#define LOG_ONEWAY(...) ALOG(LOG_DEBUG, "ipc", __VA_ARGS__)
6565

6666
#endif
6767

libs/binder/Parcel.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
#endif
4545

4646
#define LOG_REFS(...)
47-
//#define LOG_REFS(...) LOG(LOG_DEBUG, "Parcel", __VA_ARGS__)
47+
//#define LOG_REFS(...) ALOG(LOG_DEBUG, "Parcel", __VA_ARGS__)
4848

4949
// ---------------------------------------------------------------------------
5050

libs/utils/Threads.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,7 @@ static __stdcall unsigned int threadIntermediary(void* vDetails)
205205

206206
delete pDetails;
207207

208-
LOG(LOG_VERBOSE, "thread", "thread exiting\n");
208+
ALOG(LOG_VERBOSE, "thread", "thread exiting\n");
209209
return (unsigned int) result;
210210
}
211211

@@ -232,7 +232,7 @@ static bool doCreateThread(android_thread_func_t fn, void* arg, android_thread_i
232232
if (hThread == NULL)
233233
#endif
234234
{
235-
LOG(LOG_WARN, "thread", "WARNING: thread create failed\n");
235+
ALOG(LOG_WARN, "thread", "WARNING: thread create failed\n");
236236
return false;
237237
}
238238

@@ -470,7 +470,7 @@ status_t Mutex::lock()
470470
void Mutex::unlock()
471471
{
472472
if (!ReleaseMutex((HANDLE) mState))
473-
LOG(LOG_WARN, "thread", "WARNING: bad result from unlocking mutex\n");
473+
ALOG(LOG_WARN, "thread", "WARNING: bad result from unlocking mutex\n");
474474
}
475475

476476
status_t Mutex::tryLock()
@@ -479,7 +479,7 @@ status_t Mutex::tryLock()
479479

480480
dwWaitResult = WaitForSingleObject((HANDLE) mState, 0);
481481
if (dwWaitResult != WAIT_OBJECT_0 && dwWaitResult != WAIT_TIMEOUT)
482-
LOG(LOG_WARN, "thread", "WARNING: bad result from try-locking mutex\n");
482+
ALOG(LOG_WARN, "thread", "WARNING: bad result from try-locking mutex\n");
483483
return (dwWaitResult == WAIT_OBJECT_0) ? 0 : -1;
484484
}
485485

libs/utils/Timers.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ long long DurationTimer::durationUsecs(void) const
113113
/*static*/ void DurationTimer::addToTimeval(struct timeval* ptv, long usec)
114114
{
115115
if (usec < 0) {
116-
LOG(LOG_WARN, "", "Negative values not supported in addToTimeval\n");
116+
ALOG(LOG_WARN, "", "Negative values not supported in addToTimeval\n");
117117
return;
118118
}
119119

0 commit comments

Comments
 (0)