Skip to content

Commit bf5740e

Browse files
author
Jeff Brown
committed
Improve display manager debugging.
Change-Id: Iae794fe99a7cf9809f64eafb216091126a2f7e39
1 parent 98365d7 commit bf5740e

File tree

3 files changed

+29
-1
lines changed

3 files changed

+29
-1
lines changed

core/java/android/view/Display.java

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -382,5 +382,16 @@ private void updateCachedAppSizeIfNeededLocked() {
382382
mLastCachedAppSizeUpdate = now;
383383
}
384384
}
385+
386+
// For debugging purposes
387+
@Override
388+
public String toString() {
389+
synchronized (this) {
390+
updateDisplayInfoLocked();
391+
mDisplayInfo.getAppMetrics(mTempMetrics, mCompatibilityInfo);
392+
return "Display id " + mDisplayId + ": " + mDisplayInfo
393+
+ ", " + mTempMetrics;
394+
}
395+
}
385396
}
386397

core/java/android/view/DisplayInfo.java

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -223,4 +223,17 @@ private void getMetricsWithSize(DisplayMetrics outMetrics, CompatibilityInfoHold
223223
}
224224
}
225225
}
226+
227+
// For debugging purposes
228+
@Override
229+
public String toString() {
230+
return "app " + appWidth + " x " + appHeight
231+
+ ", real " + logicalWidth + " x " + logicalHeight
232+
+ ", largest app " + largestNominalAppWidth + " x " + largestNominalAppHeight
233+
+ ", smallest app " + smallestNominalAppWidth + " x " + smallestNominalAppHeight
234+
+ ", " + refreshRate + " fps"
235+
+ ", rotation " + rotation
236+
+ ", density " + logicalDensityDpi
237+
+ ", " + physicalXDpi + " x " + physicalYDpi + " dpi";
238+
}
226239
}

services/java/com/android/server/display/DisplayManagerService.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
import android.Manifest;
2020
import android.content.Context;
2121
import android.content.pm.PackageManager;
22+
import android.hardware.display.DisplayManager;
2223
import android.hardware.display.IDisplayManager;
2324
import android.os.Binder;
2425
import android.os.SystemProperties;
@@ -166,7 +167,10 @@ public void dump(FileDescriptor fd, PrintWriter pw, String[] args) {
166167
pw.println("Adapter: " + adapter.getName());
167168
}
168169

169-
pw.println("Default display: " + mDefaultDisplayInfo);
170+
pw.println("Default display info: " + mDefaultDisplayInfo);
170171
}
172+
173+
pw.println("Default display: "
174+
+ DisplayManager.getInstance().getRealDisplay(Display.DEFAULT_DISPLAY));
171175
}
172176
}

0 commit comments

Comments
 (0)