Skip to content

Commit bf0e106

Browse files
dsandlerAndroid (Google) Code Review
authored andcommitted
Merge "Cleanups in Notification.java." into jb-mr1.1-dev
2 parents 54525d8 + 6738eee commit bf0e106

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

core/java/android/app/Notification.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -388,8 +388,8 @@ public class Notification implements Parcelable
388388
* Priority is an indication of how much of the user's valuable attention should be consumed by
389389
* this notification. Low-priority notifications may be hidden from the user in certain
390390
* situations, while the user might be interrupted for a higher-priority notification. The
391-
* system will make a determination about how to interpret notification priority as described in
392-
* MUMBLE MUMBLE.
391+
* system will make a determination about how to interpret this priority when presenting
392+
* the notification.
393393
*/
394394
public int priority;
395395

@@ -846,7 +846,9 @@ public String toString() {
846846
}
847847
// TODO(dsandler): defaults take precedence over local values, so reorder the branches below
848848
sb.append(" vibrate=");
849-
if (this.vibrate != null) {
849+
if ((this.defaults & DEFAULT_VIBRATE) != 0) {
850+
sb.append("default");
851+
} else if (this.vibrate != null) {
850852
int N = this.vibrate.length-1;
851853
sb.append("[");
852854
for (int i=0; i<N; i++) {
@@ -857,16 +859,14 @@ public String toString() {
857859
sb.append(this.vibrate[N]);
858860
}
859861
sb.append("]");
860-
} else if ((this.defaults & DEFAULT_VIBRATE) != 0) {
861-
sb.append("default");
862862
} else {
863863
sb.append("null");
864864
}
865865
sb.append(" sound=");
866-
if (this.sound != null) {
867-
sb.append(this.sound.toString());
868-
} else if ((this.defaults & DEFAULT_SOUND) != 0) {
866+
if ((this.defaults & DEFAULT_SOUND) != 0) {
869867
sb.append("default");
868+
} else if (this.sound != null) {
869+
sb.append(this.sound.toString());
870870
} else {
871871
sb.append("null");
872872
}

0 commit comments

Comments
 (0)